sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart - Issue 12513006: Fix warnings in dart2js code and re-enable analyzer coverage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart

Issue 12513006: Fix warnings in dart2js code and re-enable analyzer coverage. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address review comments. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/codegen.dart ('k') | sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart b/sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart

index c1243d23a85b64df4ea6fff4862b7093dac2641c..f0552e8eb35092422e4bfda673eb39b69051d0be 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart

@@ -546,7 +546,7 @@ class VariableNamer {

// in this block can match a phi with the same name in the

// successor block.

if (temporaryIndex != 0 && regexp.hasMatch(ownName)) {

- freeTemporaryNames.addLast(ownName);

+ freeTemporaryNames.add(ownName);

}

usedNames.remove(ownName);

}