sdk/lib/_internal/compiler/implementation/ssa/bailout.dart - Issue 12513006: Fix warnings in dart2js code and re-enable analyzer coverage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/bailout.dart

Issue 12513006: Fix warnings in dart2js code and re-enable analyzer coverage. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address review comments. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/bailout.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/bailout.dart b/sdk/lib/_internal/compiler/implementation/ssa/bailout.dart

index 78ecae65c5098b5de7f79599f1621398ef826a17..da404e018782d889557f87d9c9354abc19d99cdc 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/bailout.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/bailout.dart

@@ -502,7 +502,7 @@ class SsaBailoutPropagator extends HBaseVisitor {

if (info.initializer != null) {

visitExpression(info.initializer);

}

- blocks.addLast(info.loopHeader);

+ blocks.add(info.loopHeader);

if (!info.isDoWhile()) {

visitExpression(info.condition);

}

@@ -552,7 +552,7 @@ class SsaBailoutPropagator extends HBaseVisitor {

void visitStatements(HSubGraphBlockInformation info, {bool newFlow}) {

SubGraph graph = info.subGraph;

- if (newFlow) blocks.addLast(graph.start);

+ if (newFlow) blocks.add(graph.start);

visitSubGraph(graph);

if (newFlow) blocks.removeLast();

}