Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

Issue 12513006: Fix warnings in dart2js code and re-enable analyzer coverage. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address review comments. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart b/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
index 95ad51420a17d02143a49279977fe3effe4bf5c6..6d8b6a6a8a90f634e2a1436ad1c5ead75cc29f1f 100644
--- a/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
+++ b/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
@@ -2356,22 +2356,6 @@ if (typeof document !== "undefined" && document.readyState !== "complete") {
}
}
- int _compareSelectors(Selector selector1, Selector selector2) {
- int comparison = _compareSelectorNames(selector1, selector2);
- if (comparison != 0) return comparison;
-
- Set<ClassElement> classes1 = backend.getInterceptedClassesOn(selector1);
- Set<ClassElement> classes2 = backend.getInterceptedClassesOn(selector2);
- if (classes1.length != classes2.length) {
- return classes1.length - classes2.length;
- }
- String getInterceptor1 =
- namer.getInterceptorName(backend.getInterceptorMethod, classes1);
- String getInterceptor2 =
- namer.getInterceptorName(backend.getInterceptorMethod, classes2);
- return Comparable.compare(getInterceptor1, getInterceptor2);
- }
-
// Optimize performance critical one shot interceptors.
jsAst.Statement tryOptimizeOneShotInterceptor(Selector selector,
Set<ClassElement> classes) {

Powered by Google App Engine
This is Rietveld 408576698