Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1249013002: DevTools: simplify setScriptSource and restartFrame return values (Closed)

Created:
5 years, 5 months ago by yurys
Modified:
5 years, 5 months ago
Reviewers:
dgozman, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: simplify setScriptSource and restartFrame return values For the live edit it is always boolean instead of object. For restart frame we always need to do step in after restart, so there is no need to pass additional parameter in the result. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199319

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed dgozman's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -50 lines) Patch
M Source/core/inspector/DebuggerScript.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InjectedScript.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InjectedScript.cpp View 1 2 chunks +5 lines, -6 lines 0 comments Download
M Source/core/inspector/InjectedScriptSource.js View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/v8/V8Debugger.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/v8/V8DebuggerImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/v8/V8DebuggerImpl.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/devtools/front_end/sdk/DebuggerModel.js View 2 chunks +2 lines, -18 lines 0 comments Download
M Source/devtools/front_end/sdk/Script.js View 1 chunk +3 lines, -4 lines 0 comments Download
M Source/devtools/protocol.json View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
yurys
5 years, 5 months ago (2015-07-22 14:58:40 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1249013002/1
5 years, 5 months ago (2015-07-22 14:59:07 UTC) #4
dgozman
lgtm https://codereview.chromium.org/1249013002/diff/1/Source/core/inspector/InjectedScript.cpp File Source/core/inspector/InjectedScript.cpp (right): https://codereview.chromium.org/1249013002/diff/1/Source/core/inspector/InjectedScript.cpp#newcode183 Source/core/inspector/InjectedScript.cpp:183: ASSERT(resultValue->type() == JSONValue::TypeBoolean); Let's ASSERT it's |true|.
5 years, 5 months ago (2015-07-22 15:13:34 UTC) #5
yurys
https://codereview.chromium.org/1249013002/diff/1/Source/core/inspector/InjectedScript.cpp File Source/core/inspector/InjectedScript.cpp (right): https://codereview.chromium.org/1249013002/diff/1/Source/core/inspector/InjectedScript.cpp#newcode183 Source/core/inspector/InjectedScript.cpp:183: ASSERT(resultValue->type() == JSONValue::TypeBoolean); On 2015/07/22 15:13:34, dgozman wrote: > ...
5 years, 5 months ago (2015-07-22 15:19:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1249013002/20001
5 years, 5 months ago (2015-07-22 15:23:08 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 16:43:22 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199319

Powered by Google App Engine
This is Rietveld 408576698