Source/core/inspector/InjectedScriptSource.js - Issue 1249013002: DevTools: simplify setScriptSource and restartFrame return values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InjectedScriptSource.js

Issue 1249013002: DevTools: simplify setScriptSource and restartFrame return values (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Addressed dgozman's comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/inspector/InjectedScriptSource.js

diff --git a/Source/core/inspector/InjectedScriptSource.js b/Source/core/inspector/InjectedScriptSource.js

index 214b74400eeac3c0be8a4ccefb26af062c947a74..f8f2343b90c7cc38de1252244f155e73486e7bd5 100644

--- a/Source/core/inspector/InjectedScriptSource.js

+++ b/Source/core/inspector/InjectedScriptSource.js

@@ -959,10 +959,7 @@ InjectedScript.prototype = {

var callFrame = this._callFrameForId(topCallFrame, callFrameId);

if (!callFrame)

return "Could not find call frame with given id";

- var result = callFrame.restart();

- if (result === false)

- result = "Restart frame is not supported";

- return result;

+ return callFrame.restart();

/**