Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1365)

Unified Diff: Source/core/inspector/v8/V8DebuggerImpl.cpp

Issue 1249013002: DevTools: simplify setScriptSource and restartFrame return values (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed dgozman's comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/v8/V8DebuggerImpl.h ('k') | Source/devtools/front_end/sdk/DebuggerModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/v8/V8DebuggerImpl.cpp
diff --git a/Source/core/inspector/v8/V8DebuggerImpl.cpp b/Source/core/inspector/v8/V8DebuggerImpl.cpp
index 10f29ef44fadd3230c2de21e0823b884d00cf7bf..0348a70a34b5fa8f13979403409c71d683733399 100644
--- a/Source/core/inspector/v8/V8DebuggerImpl.cpp
+++ b/Source/core/inspector/v8/V8DebuggerImpl.cpp
@@ -298,7 +298,7 @@ void V8DebuggerImpl::clearStepping()
callDebuggerMethod("clearStepping", 0, argv);
}
-bool V8DebuggerImpl::setScriptSource(const String& sourceID, const String& newContent, bool preview, String* error, RefPtr<TypeBuilder::Debugger::SetScriptSourceError>& errorData, v8::Global<v8::Object>* newCallFrames, RefPtr<JSONObject>* result)
+bool V8DebuggerImpl::setScriptSource(const String& sourceID, const String& newContent, bool preview, String* error, RefPtr<TypeBuilder::Debugger::SetScriptSourceError>& errorData, v8::Global<v8::Object>* newCallFrames, TypeBuilder::OptOutput<bool>* stackChanged)
{
class EnableLiveEditScope {
public:
@@ -339,10 +339,7 @@ bool V8DebuggerImpl::setScriptSource(const String& sourceID, const String& newCo
switch (code) {
case 0:
{
- v8::Local<v8::Value> normalResult = resultTuple->Get(1);
- RefPtr<JSONValue> jsonResult = toJSONValue(m_isolate, normalResult);
- if (jsonResult)
- *result = jsonResult->asObject();
+ *stackChanged = resultTuple->Get(1)->BooleanValue();
// Call stack may have changed after if the edited function was on the stack.
if (!preview && isPaused())
newCallFrames->Reset(m_isolate, currentCallFrames());
« no previous file with comments | « Source/core/inspector/v8/V8DebuggerImpl.h ('k') | Source/devtools/front_end/sdk/DebuggerModel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698