Source/core/inspector/v8/V8DebuggerImpl.h - Issue 1249013002: DevTools: simplify setScriptSource and restartFrame return values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/v8/V8DebuggerImpl.h

Issue 1249013002: DevTools: simplify setScriptSource and restartFrame return values (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Addressed dgozman's comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/inspector/v8/V8DebuggerImpl.h

diff --git a/Source/core/inspector/v8/V8DebuggerImpl.h b/Source/core/inspector/v8/V8DebuggerImpl.h

index 88850a8ed4a3d57789c4fdef222193a326f8e1f6..6905d653064e3864354d49e481884392e7ac6b9a 100644

--- a/Source/core/inspector/v8/V8DebuggerImpl.h

+++ b/Source/core/inspector/v8/V8DebuggerImpl.h

@@ -78,7 +78,7 @@ public:

void stepOutOfFunction() override;

void clearStepping() override;

- bool setScriptSource(const String& sourceID, const String& newContent, bool preview, String* error, RefPtr<TypeBuilder::Debugger::SetScriptSourceError>&, v8::Global<v8::Object>* newCallFrames, RefPtr<JSONObject>* result) override;

+ bool setScriptSource(const String& sourceID, const String& newContent, bool preview, String* error, RefPtr<TypeBuilder::Debugger::SetScriptSourceError>&, v8::Global<v8::Object>* newCallFrames, TypeBuilder::OptOutput<bool>* stackChanged) override;

v8::Local<v8::Object> currentCallFrames() override;

v8::Local<v8::Object> currentCallFramesForAsyncStack() override;

PassRefPtr<JavaScriptCallFrame> callFrameNoScopes(int index) override;

« no previous file with comments | « Source/core/inspector/v8/V8Debugger.h ('k') | Source/core/inspector/v8/V8DebuggerImpl.cpp » ('j') | no next file with comments »