Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(986)

Unified Diff: Source/devtools/front_end/sdk/DebuggerModel.js

Issue 1249013002: DevTools: simplify setScriptSource and restartFrame return values (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed dgozman's comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/v8/V8DebuggerImpl.cpp ('k') | Source/devtools/front_end/sdk/Script.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/sdk/DebuggerModel.js
diff --git a/Source/devtools/front_end/sdk/DebuggerModel.js b/Source/devtools/front_end/sdk/DebuggerModel.js
index 9e18b1813515fff702b90322aabb23567c536800..f99996f15ef0de15a432248c9a773f3211a2e09d 100644
--- a/Source/devtools/front_end/sdk/DebuggerModel.js
+++ b/Source/devtools/front_end/sdk/DebuggerModel.js
@@ -729,21 +729,6 @@ WebInspector.DebuggerModel.prototype = {
this.selectedCallFrame().evaluate(code, objectGroup, includeCommandLineAPI, doNotPauseOnExceptionsAndMuteConsole, returnByValue, generatePreview, didEvaluate.bind(this));
},
- /**
- * Handles notification from JavaScript VM about updated stack (liveedit or frame restart action).
- * @param {!Array.<!DebuggerAgent.CallFrame>=} newCallFrames
- * @param {!Object=} details
- * @param {!DebuggerAgent.StackTrace=} asyncStackTrace
- */
- callStackModified: function(newCallFrames, details, asyncStackTrace)
- {
- // FIXME: declare this property in protocol and in JavaScript.
- if (details && details["stack_update_needs_step_in"])
- this.stepInto();
- else if (newCallFrames && newCallFrames.length)
- this._pausedScript(newCallFrames, this._debuggerPausedDetails.reason, this._debuggerPausedDetails.auxData, this._debuggerPausedDetails.breakpointIds, asyncStackTrace);
- },
-
_applySkipStackFrameSettings: function()
{
this._agent.skipStackFrames(WebInspector.moduleSetting("skipStackFramesPattern").get(), WebInspector.moduleSetting("skipContentScripts").get());
@@ -1281,14 +1266,13 @@ WebInspector.DebuggerModel.CallFrame.prototype = {
/**
* @param {?Protocol.Error} error
* @param {!Array.<!DebuggerAgent.CallFrame>=} callFrames
- * @param {!Object=} details
* @param {!DebuggerAgent.StackTrace=} asyncStackTrace
* @this {WebInspector.DebuggerModel.CallFrame}
*/
- function protocolCallback(error, callFrames, details, asyncStackTrace)
+ function protocolCallback(error, callFrames, asyncStackTrace)
{
if (!error)
- this.debuggerModel.callStackModified(callFrames, details, asyncStackTrace);
+ this.debuggerModel.stepInto();
if (callback)
callback(error);
}
« no previous file with comments | « Source/core/inspector/v8/V8DebuggerImpl.cpp ('k') | Source/devtools/front_end/sdk/Script.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698