Source/core/inspector/InjectedScript.h - Issue 1249013002: DevTools: simplify setScriptSource and restartFrame return values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InjectedScript.h

Issue 1249013002: DevTools: simplify setScriptSource and restartFrame return values (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Addressed dgozman's comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/inspector/InjectedScript.h

diff --git a/Source/core/inspector/InjectedScript.h b/Source/core/inspector/InjectedScript.h

index 59030a99e9cf7b8c02cac7dd354d9ab0a543010b..bfe33e4a3f7337862db14bb92d88d6825592b421 100644

--- a/Source/core/inspector/InjectedScript.h

+++ b/Source/core/inspector/InjectedScript.h

@@ -92,7 +92,7 @@ public:

RefPtr<TypeBuilder::Runtime::RemoteObject>* result,

TypeBuilder::OptOutput<bool>* wasThrown,

RefPtr<TypeBuilder::Debugger::ExceptionDetails>*);

- void restartFrame(ErrorString*, v8::Local<v8::Object> callFrames, const String& callFrameId, RefPtr<JSONObject>* result);

+ void restartFrame(ErrorString*, v8::Local<v8::Object> callFrames, const String& callFrameId);

void getStepInPositions(ErrorString*, v8::Local<v8::Object> callFrames, const String& callFrameId, RefPtr<TypeBuilder::Array<TypeBuilder::Debugger::Location>>& positions);

void setVariableValue(ErrorString*, v8::Local<v8::Object> callFrames, const String* callFrameIdOpt, const String* functionObjectIdOpt, int scopeNumber, const String& variableName, const String& newValueStr);

void getFunctionDetails(ErrorString*, const String& functionId, RefPtr<TypeBuilder::Debugger::FunctionDetails>* result);

« no previous file with comments | « Source/core/inspector/DebuggerScript.js ('k') | Source/core/inspector/InjectedScript.cpp » ('j') | no next file with comments »