Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1246013004: Make ARM RegNames[] static like X86 (no ARM syms in X86-only build). (Closed)

Created:
5 years, 5 months ago by jvoung (off chromium)
Modified:
5 years, 5 months ago
Reviewers:
Jim Stichnoth, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make ARM RegNames[] static like X86 (no ARM syms in X86-only build). The X86 code was switch out here: https://codereview.chromium.org/1216933015/diff/150001/src/IceTargetLoweringX86Base.h The important bit might be that it's static const char * instead of static IceString. This removes static ctor/dtor for that array, which LTO doesn't seem to be able to optimize out, leaving ARM and MIPS symbols in the X86-only build. After changing it to static const char *, LTO is able to optimize out the ARM and MIPS symbols in the x86-only build, saving about 3KB of .text and few bytes of .rodata. BUG=none R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=0dab032401107239f48cab3605b1f268891cd14e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M src/IceTargetLoweringARM32.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/IceTargetLoweringARM32.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M src/IceTargetLoweringMIPS32.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/IceTargetLoweringMIPS32.cpp View 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jvoung (off chromium)
5 years, 5 months ago (2015-07-21 17:52:02 UTC) #2
John
lgtm
5 years, 5 months ago (2015-07-21 20:45:29 UTC) #3
jvoung (off chromium)
5 years, 5 months ago (2015-07-21 21:29:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0dab032401107239f48cab3605b1f268891cd14e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698