Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12391055: Cleaned up CpuFeature scope handling. (Closed)

Created:
7 years, 9 months ago by Sven Panne
Modified:
7 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Cleaned up CpuFeature scope handling. First of all, it has nothing to do with Isolates, it is related to the assembler at hand. Furthermore, the saving/restoring is platform-independent. Cleaned up some platform-specific stuff on the way. Note that there are some things which still need some cleanup, like e.g. using EnumSet instead of uint64_t, making Probe() more uniform across platforms etc., but the CL is already big enough. BUG=v8:2487 Committed: http://code.google.com/p/v8/source/detail?r=13823

Patch Set 1 #

Patch Set 2 : ARM and MIPS support #

Total comments: 4

Patch Set 3 : Fixed nits #

Patch Set 4 : Fixed nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+550 lines, -676 lines) Patch
M src/arm/assembler-arm.h View 1 3 chunks +5 lines, -50 lines 0 comments Download
M src/arm/assembler-arm.cc View 40 chunks +59 lines, -51 lines 0 comments Download
M src/arm/code-stubs-arm.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 2 30 chunks +35 lines, -41 lines 0 comments Download
M src/arm/codegen-arm.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/deoptimizer-arm.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 2 38 chunks +38 lines, -38 lines 0 comments Download
M src/arm/lithium-gap-resolver-arm.cc View 1 5 chunks +7 lines, -7 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 2 10 chunks +10 lines, -10 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M src/assembler.h View 3 chunks +25 lines, -0 lines 0 comments Download
M src/assembler.cc View 1 2 2 chunks +31 lines, -0 lines 0 comments Download
M src/ia32/assembler-ia32.h View 1 3 chunks +7 lines, -50 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 2 54 chunks +57 lines, -58 lines 0 comments Download
M src/ia32/code-stubs-ia32.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 23 chunks +26 lines, -26 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 38 chunks +41 lines, -41 lines 0 comments Download
M src/ia32/lithium-gap-resolver-ia32.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M src/isolate.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/assembler-mips.h View 1 3 chunks +5 lines, -49 lines 0 comments Download
M src/mips/assembler-mips.cc View 13 chunks +15 lines, -15 lines 0 comments Download
M src/mips/code-stubs-mips.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 2 31 chunks +36 lines, -42 lines 0 comments Download
M src/mips/codegen-mips.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips/deoptimizer-mips.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 2 33 chunks +33 lines, -33 lines 0 comments Download
M src/mips/lithium-gap-resolver-mips.cc View 1 5 chunks +7 lines, -7 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 15 chunks +15 lines, -15 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M src/x64/assembler-x64.h View 1 3 chunks +8 lines, -51 lines 0 comments Download
M src/x64/assembler-x64.cc View 7 chunks +13 lines, -12 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 8 chunks +8 lines, -8 lines 0 comments Download
M test/cctest/test-assembler-ia32.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M test/cctest/test-disasm-arm.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sven Panne
7 years, 9 months ago (2013-03-04 12:17:26 UTC) #1
Michael Starzinger
LGTM, nits only. https://codereview.chromium.org/12391055/diff/46/src/assembler.cc File src/assembler.cc (right): https://codereview.chromium.org/12391055/diff/46/src/assembler.cc#newcode184 src/assembler.cc:184: // Implementation of PredictableCodeSizeScope Comment should ...
7 years, 9 months ago (2013-03-05 09:31:11 UTC) #2
Sven Panne
Nits addressed, landing... https://codereview.chromium.org/12391055/diff/46/src/assembler.cc File src/assembler.cc (right): https://codereview.chromium.org/12391055/diff/46/src/assembler.cc#newcode184 src/assembler.cc:184: // Implementation of PredictableCodeSizeScope On 2013/03/05 ...
7 years, 9 months ago (2013-03-05 10:38:01 UTC) #3
Sven Panne
7 years, 9 months ago (2013-03-05 10:48:39 UTC) #4
Message was sent while issue was closed. 
Committed patchset #4 manually as r13823 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698