Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1664)

Unified Diff: test/cctest/test-assembler-ia32.cc

Issue 12391055: Cleaned up CpuFeature scope handling. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fixed nits Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-assembler-arm.cc ('k') | test/cctest/test-disasm-arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-assembler-ia32.cc
diff --git a/test/cctest/test-assembler-ia32.cc b/test/cctest/test-assembler-ia32.cc
index 76eca0d56815d9eb35392b66663244118e903569..e92e48f83c0176cd190da1cd11504b4e4b67ac61 100644
--- a/test/cctest/test-assembler-ia32.cc
+++ b/test/cctest/test-assembler-ia32.cc
@@ -180,7 +180,7 @@ TEST(AssemblerIa323) {
Assembler assm(isolate, buffer, sizeof buffer);
CHECK(CpuFeatures::IsSupported(SSE2));
- { CpuFeatures::Scope fscope(SSE2);
+ { CpuFeatureScope fscope(&assm, SSE2);
__ cvttss2si(eax, Operand(esp, 4));
__ ret(0);
}
@@ -216,7 +216,7 @@ TEST(AssemblerIa324) {
Assembler assm(isolate, buffer, sizeof buffer);
CHECK(CpuFeatures::IsSupported(SSE2));
- CpuFeatures::Scope fscope(SSE2);
+ CpuFeatureScope fscope(&assm, SSE2);
__ cvttsd2si(eax, Operand(esp, 4));
__ ret(0);
@@ -269,12 +269,11 @@ TEST(AssemblerIa326) {
if (!CpuFeatures::IsSupported(SSE2)) return;
v8::HandleScope scope;
- CHECK(CpuFeatures::IsSupported(SSE2));
- CpuFeatures::Scope fscope(SSE2);
v8::internal::byte buffer[256];
Isolate* isolate = Isolate::Current();
Assembler assm(isolate, buffer, sizeof buffer);
+ CpuFeatureScope fscope(&assm, SSE2);
__ movdbl(xmm0, Operand(esp, 1 * kPointerSize));
__ movdbl(xmm1, Operand(esp, 3 * kPointerSize));
__ addsd(xmm0, xmm1);
@@ -316,11 +315,10 @@ TEST(AssemblerIa328) {
if (!CpuFeatures::IsSupported(SSE2)) return;
v8::HandleScope scope;
- CHECK(CpuFeatures::IsSupported(SSE2));
- CpuFeatures::Scope fscope(SSE2);
v8::internal::byte buffer[256];
Isolate* isolate = Isolate::Current();
Assembler assm(isolate, buffer, sizeof buffer);
+ CpuFeatureScope fscope(&assm, SSE2);
__ mov(eax, Operand(esp, 4));
__ cvtsi2sd(xmm0, eax);
// Copy xmm0 to st(0) using eight bytes of stack.
« no previous file with comments | « test/cctest/test-assembler-arm.cc ('k') | test/cctest/test-disasm-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698