Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 1236543004: GN (android): Append ".cr" to component .so's to avoid zygote lib collisions (Closed)

Created:
5 years, 5 months ago by agrieve
Modified:
5 years, 5 months ago
Reviewers:
cjhopman, brettw
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn16
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN (android): Append ".cr" to component .so's to avoid zygote lib collisions With this, ChromePublic now launches with is_component_build = true BUG=500882 Committed: https://crrev.com/a2daf08ffddf4549160f3925383b457a2eb03c7f Cr-Commit-Position: refs/heads/master@{#338612}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Don't modify BUILDCONFIG #

Patch Set 4 : fix mojo_application #

Patch Set 5 : fix android gn check #

Patch Set 6 : fix android gn check 2 #

Patch Set 7 : android_shared_library_extension -> android_product_extension (to match GYP) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -18 lines) Patch
M build/config/android/config.gni View 1 2 3 4 5 6 2 chunks +5 lines, -1 line 0 comments Download
M build/config/android/rules.gni View 1 2 3 4 5 6 3 chunks +9 lines, -7 lines 0 comments Download
M build/toolchain/android/BUILD.gn View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M build/toolchain/gcc_toolchain.gni View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M components/resource_provider/BUILD.gn View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M mandoline/app/android/BUILD.gn View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M mandoline/services/updater/BUILD.gn View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/mojo_application.gni View 1 2 3 4 5 6 2 chunks +6 lines, -1 line 0 comments Download
M mojo/runner/BUILD.gn View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/services/network/BUILD.gn View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
agrieve
5 years, 5 months ago (2015-07-11 02:15:54 UTC) #2
brettw
owners lgtm but Chris should definitely review.
5 years, 5 months ago (2015-07-13 17:04:57 UTC) #3
cjhopman
lgtm
5 years, 5 months ago (2015-07-13 21:59:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236543004/120001
5 years, 5 months ago (2015-07-14 00:58:26 UTC) #7
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 5 months ago (2015-07-14 01:30:53 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 01:31:44 UTC) #9
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/a2daf08ffddf4549160f3925383b457a2eb03c7f
Cr-Commit-Position: refs/heads/master@{#338612}

Powered by Google App Engine
This is Rietveld 408576698