build/toolchain/gcc_toolchain.gni - Issue 1236543004: GN (android): Append ".cr" to component .so's to avoid zygote lib collisions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/toolchain/gcc_toolchain.gni

Issue 1236543004: GN (android): Append ".cr" to component .so's to avoid zygote lib collisions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn16

Patch Set: android_shared_library_extension -> android_product_extension (to match GYP) Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/toolchain/gcc_toolchain.gni

diff --git a/build/toolchain/gcc_toolchain.gni b/build/toolchain/gcc_toolchain.gni

index 31c505c40ff454831f30edcb9a48a23172930a7a..3421a9575bda75ed497f57cf2ec3b7e8b3587123 100644

--- a/build/toolchain/gcc_toolchain.gni

+++ b/build/toolchain/gcc_toolchain.gni

@@ -160,6 +160,9 @@ template("gcc_toolchain") {

# overrides it (in which case {{output_extension}} will be what the target

# specifies).

default_output_extension = ".so"

+ if (defined(invoker.default_output_extension)) {

+ default_output_extension = invoker.default_output_extension

+ }

output_prefix = "lib"

« no previous file with comments | « build/toolchain/android/BUILD.gn ('k') | components/resource_provider/BUILD.gn » ('j') | no next file with comments »