build/toolchain/android/BUILD.gn - Issue 1236543004: GN (android): Append ".cr" to component .so's to avoid zygote lib collisions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/toolchain/android/BUILD.gn

Issue 1236543004: GN (android): Append ".cr" to component .so's to avoid zygote lib collisions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn16

Patch Set: android_shared_library_extension -> android_product_extension (to match GYP) Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/toolchain/android/BUILD.gn

diff --git a/build/toolchain/android/BUILD.gn b/build/toolchain/android/BUILD.gn

index 1380c4abc0cecb4302ee763959abaf13c17a278d..087f04b3506331bd1d6c631f49074f03ffea449e 100644

--- a/build/toolchain/android/BUILD.gn

+++ b/build/toolchain/android/BUILD.gn

@@ -69,6 +69,7 @@ template("android_gcc_toolchain") {

replace_command = "if ! cmp -s $temp_stripped_soname $stripped_soname; then mv $temp_stripped_soname $stripped_soname; fi"

postsolink = "$strip_command && $replace_command"

solink_outputs = [ stripped_soname ]

+ default_output_extension = android_product_extension

# We make the assumption that the gcc_toolchain will produce an exe with

# the following definition.

« no previous file with comments | « build/config/android/rules.gni ('k') | build/toolchain/gcc_toolchain.gni » ('j') | no next file with comments »