build/config/android/config.gni - Issue 1236543004: GN (android): Append ".cr" to component .so's to avoid zygote lib collisions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/android/config.gni

Issue 1236543004: GN (android): Append ".cr" to component .so's to avoid zygote lib collisions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn16

Patch Set: android_shared_library_extension -> android_product_extension (to match GYP) Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/android/config.gni

diff --git a/build/config/android/config.gni b/build/config/android/config.gni

index 192a502987ae400540296b41642122164819f60b..f11ac41b62f203a4c7e57459730810556bb2d0a2 100644

--- a/build/config/android/config.gni

+++ b/build/config/android/config.gni

@@ -162,7 +162,7 @@ if (is_android) {

android_gdbserver =

"$android_ndk_root/prebuilt/$android_prebuilt_arch/gdbserver/gdbserver"

- # libc++ stuff ---------------------------------------------------------------

+ # Toolchain stuff ------------------------------------------------------------

android_libcpp_root = "$android_ndk_root/sources/cxx-stl/llvm-libc++"

if (component_mode == "shared_library") {

@@ -171,6 +171,10 @@ if (is_android) {

android_libcpp_library = "c++_static"

}

+ # By appending .cr, we prevent name collisions with libraries already

+ # loaded by the Android zygote.

+ android_product_extension = ".cr.so"

# ABI ------------------------------------------------------------------------

if (current_cpu == "x86") {

« no previous file with comments | « no previous file | build/config/android/rules.gni » ('j') | no next file with comments »