Standardize parameters passed when Tabs are created asynchronously.

Standardize parameters passed when Tabs are created asynchronously.

* Pulls out PendingDocumentData from the DocumentTabModelSelector and makes
  it a standalone thing.  The new AsyncTabCreationParamsManager acts as the
  DocumentTabModelSelector did and stores a mapping of Tab IDs to pending
  data, which are now stored in AsyncTabCreationParams.

* Callsites are all changed to use the new AsyncTabCreationParams instead.

* AsyncTabCreationParams now stores a LoadUrlParams instead of random fields
  from the LoadUrlParams.

* Fields in the AsyncTabCreationParams are clearly marked exclusive, based
  on how they are constructed.

BUG=508333
Committed: https://crrev.com/b24a3b7041f8f269483afa6e9708562b32667fd3
Cr-Commit-Position: refs/heads/master@{#338411}

[gone, 2015-07-10 23:05:22]

dfalcantara@chromium.org changed reviewers:
+ dtrainor@chromium.org, mariakhomenko@chromium.org

[gone, 2015-07-10 23:05:23]

Maria: if you've got time to kill before disappearing, PTAL.

[Maria, 2015-07-10 23:45:46]

https://codereview.chromium.org/1235523003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/AsyncTabCreationParamsManager.java
(right):

https://codereview.chromium.org/1235523003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/AsyncTabCreationParamsManager.java:45:
synchronized (ASYNC_TAB_CREATION_PARAMS) {
why do we need to synchronize this if we are asserting that this only gets
called on the UI thread?

[gone, 2015-07-10 23:53:04]

https://codereview.chromium.org/1235523003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/AsyncTabCreationParamsManager.java
(right):

https://codereview.chromium.org/1235523003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/AsyncTabCreationParamsManager.java:45:
synchronized (ASYNC_TAB_CREATION_PARAMS) {
On 2015/07/10 23:45:46, Maria wrote:
> why do we need to synchronize this if we are asserting that this only gets
> called on the UI thread?

Paranoia over findbugs.  Will run it through and see if it's fine.

[Maria, 2015-07-10 23:55:14]

https://codereview.chromium.org/1235523003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java
(right):

https://codereview.chromium.org/1235523003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java:466:
// Try to retarget an existing task.  Make sure there is no pending data to go
with the load
this comment has gone stale, I'd rephrase

https://codereview.chromium.org/1235523003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java
(right):

https://codereview.chromium.org/1235523003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java:454:
AsyncTabCreationParams pendingData = AsyncTabCreationParamsManager.remove(
maybe rename this from pendingData to something more suitable?

https://codereview.chromium.org/1235523003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/AsyncTabCreationParamsManager.java
(right):

https://codereview.chromium.org/1235523003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/AsyncTabCreationParamsManager.java:15:
public class AsyncTabCreationParamsManager {
I know this class is really simple, but I think it would be nice to have a test
verifying it works. Seems like it could even be a unit test.

[Maria, 2015-07-10 23:56:42]

On 2015/07/10 23:53:04, dfalcantara wrote:
>
https://codereview.chromium.org/1235523003/diff/1/chrome/android/java/src/org...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/AsyncTabCreationParamsManager.java
> (right):
> 
>
https://codereview.chromium.org/1235523003/diff/1/chrome/android/java/src/org...
>
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/AsyncTabCreationParamsManager.java:45:
> synchronized (ASYNC_TAB_CREATION_PARAMS) {
> On 2015/07/10 23:45:46, Maria wrote:
> > why do we need to synchronize this if we are asserting that this only gets
> > called on the UI thread?
> 
> Paranoia over findbugs.  Will run it through and see if it's fine.

I think simplifying our code and hitting findbugs on the head with a mallet
would be a preferable approach.

[Maria, 2015-07-10 23:56:52]

lgtm

[gone, 2015-07-11 00:03:06]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2015-07-11 00:03:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
mariakhomenko@chromium.org
Link to the patchset: https://codereview.chromium.org/1235523003/#ps40001
(title: "Addressing comments")

[gone, 2015-07-11 00:03:11]

The CQ bit was unchecked by dfalcantara@chromium.org

[gone, 2015-07-11 00:03:28]

https://codereview.chromium.org/1235523003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java
(right):

https://codereview.chromium.org/1235523003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java:466:
// Try to retarget an existing task.  Make sure there is no pending data to go
with the load
On 2015/07/10 23:55:14, Maria wrote:
> this comment has gone stale, I'd rephrase

Done.

https://codereview.chromium.org/1235523003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java
(right):

https://codereview.chromium.org/1235523003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java:454:
AsyncTabCreationParams pendingData = AsyncTabCreationParamsManager.remove(
On 2015/07/10 23:55:14, Maria wrote:
> maybe rename this from pendingData to something more suitable?

Done.

https://codereview.chromium.org/1235523003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/AsyncTabCreationParamsManager.java
(right):

https://codereview.chromium.org/1235523003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/AsyncTabCreationParamsManager.java:15:
public class AsyncTabCreationParamsManager {
On 2015/07/10 23:55:14, Maria wrote:
> I know this class is really simple, but I think it would be nice to have a
test
> verifying it works. Seems like it could even be a unit test.

Will land a separate CL for it.

[gone, 2015-07-11 00:03:41]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2015-07-11 00:05:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1235523003/40001

[commit-bot: I haz the power, 2015-07-11 00:38:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-11 00:39:16]

Patchset 3 (id:??) landed as
https://crrev.com/b24a3b7041f8f269483afa6e9708562b32667fd3
Cr-Commit-Position: refs/heads/master@{#338411}