chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java - Issue 1235523003: Standardize parameters passed when Tabs are created asynchronously.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java

Issue 1235523003: Standardize parameters passed when Tabs are created asynchronously. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeTestBase.java ('k') | chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/tabmodel/document/MockTabDelegate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java

diff --git a/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java b/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java

index cad666d7ff6d99a6794626915473b896895fcc2f..9e0e8fe94b4284ccf54150b2f134e8caac932fd4 100644

--- a/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java

+++ b/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java

@@ -40,7 +40,6 @@ import org.chromium.chrome.browser.DeferredStartupHandler;

import org.chromium.chrome.browser.Tab;

import org.chromium.chrome.browser.document.ChromeLauncherActivity;

import org.chromium.chrome.browser.document.DocumentActivity;

-import org.chromium.chrome.browser.document.DocumentMetricIds;

import org.chromium.chrome.browser.document.DocumentUtils;

import org.chromium.chrome.browser.document.IncognitoDocumentActivity;

import org.chromium.chrome.browser.infobar.InfoBar;

@@ -61,6 +60,7 @@ import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;

import org.chromium.chrome.browser.tabmodel.TabModel.TabSelectionType;

import org.chromium.chrome.browser.tabmodel.TabModelObserver;

import org.chromium.chrome.browser.tabmodel.TabModelSelector;

+import org.chromium.chrome.browser.tabmodel.document.AsyncTabCreationParams;

import org.chromium.chrome.browser.util.FeatureUtilities;

import org.chromium.chrome.test.util.ActivityUtils;

import org.chromium.chrome.test.util.ApplicationData;

@@ -467,10 +467,10 @@ public abstract class ChromeActivityTestCaseBase<T extends ChromeActivity>

ThreadUtils.runOnUiThreadBlocking(new Runnable() {

@Override

public void run() {

- ChromeLauncherActivity.launchDocumentInstance(getActivity(), incognito,

- ChromeLauncherActivity.LAUNCH_MODE_FOREGROUND, url,

- DocumentMetricIds.STARTED_BY_UNKNOWN,

- PageTransition.AUTO_TOPLEVEL, null);

+ AsyncTabCreationParams asyncParams = new AsyncTabCreationParams(

+ new LoadUrlParams(url, PageTransition.AUTO_TOPLEVEL));

+ ChromeLauncherActivity.launchDocumentInstance(

+ getActivity(), incognito, asyncParams);

}

});

}