Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1517)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java

Issue 1235523003: Standardize parameters passed when Tabs are created asynchronously. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java
index 08cbe9dbc335bf9a9dad5b6912916c223fb24499..d781162652152d518f94b18cb664e6f408c19a6f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java
@@ -8,8 +8,8 @@ import android.content.Context;
import org.chromium.chrome.browser.document.DocumentMetricIds;
import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;
+import org.chromium.chrome.browser.tabmodel.document.AsyncTabCreationParams;
import org.chromium.chrome.browser.tabmodel.document.TabDelegate;
-import org.chromium.chrome.browser.tabmodel.document.TabDelegate.AsyncTabCreationParams;
import org.chromium.components.service_tab_launcher.ServiceTabLauncher;
import org.chromium.content_public.browser.LoadUrlParams;
import org.chromium.content_public.common.Referrer;
@@ -40,12 +40,10 @@ public class ChromeServiceTabLauncher extends ServiceTabLauncher {
loadUrlParams.setVerbatimHeaders(extraHeaders);
loadUrlParams.setReferrer(new Referrer(referrerUrl, referrerPolicy));
- AsyncTabCreationParams additionalParams = new AsyncTabCreationParams();
- additionalParams.documentStartedBy = intentSource;
- additionalParams.requestId = requestId;
+ AsyncTabCreationParams asyncParams = new AsyncTabCreationParams(loadUrlParams, requestId);
+ asyncParams.setDocumentStartedBy(intentSource);
TabDelegate tabDelegate = new TabDelegate(incognito);
- tabDelegate.createNewTab(
- loadUrlParams, TabLaunchType.FROM_MENU_OR_OVERVIEW, null, additionalParams);
+ tabDelegate.createNewTab(asyncParams, TabLaunchType.FROM_MENU_OR_OVERVIEW, null);
}
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698