Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1166)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/AsyncTabCreationParamsManager.java

Issue 1235523003: Standardize parameters passed when Tabs are created asynchronously. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/AsyncTabCreationParamsManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/AsyncTabCreationParamsManager.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/AsyncTabCreationParamsManager.java
new file mode 100644
index 0000000000000000000000000000000000000000..bf860cb44d69df106e6e6c66f9adb8c15e841db5
--- /dev/null
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/AsyncTabCreationParamsManager.java
@@ -0,0 +1,48 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.tabmodel.document;
+
+import android.util.SparseArray;
+
+import org.chromium.base.ThreadUtils;
+
+/**
+ * Data that will be used later when a tab is opened via an intent. Often only the necessary
+ * subset of the data will be set. All data is removed once the tab finishes initializing.
+ */
+public class AsyncTabCreationParamsManager {
+ /** A map of tab IDs to AsyncTabCreationParams consumed by Activities started asynchronously. */
+ private static SparseArray<AsyncTabCreationParams> sAsyncTabCreationParams;
+
+ /**
+ * Stores AsyncTabCreationParams used when the tab with the given ID is launched via intent.
+ * @param tabId The ID of the tab that will be launched via intent.
+ * @param params The AsyncTabCreationParams to use when creating the Tab.
+ */
+ public static void add(int tabId, AsyncTabCreationParams params) {
+ ensureInitialized();
+ sAsyncTabCreationParams.put(tabId, params);
+ }
+
+ /**
+ * @return Retrieves and removes AsyncTabCreationParams for a particular tab id.
+ */
+ public static AsyncTabCreationParams remove(int tabId) {
+ ensureInitialized();
+ AsyncTabCreationParams data = sAsyncTabCreationParams.get(tabId);
+ sAsyncTabCreationParams.remove(tabId);
+ return data;
+ }
+
+ private static void ensureInitialized() {
+ ThreadUtils.assertOnUiThread();
+ if (sAsyncTabCreationParams == null) {
+ sAsyncTabCreationParams = new SparseArray<AsyncTabCreationParams>();
+ }
+ }
+
+ private AsyncTabCreationParamsManager() {
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698