Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2704)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelSelector.java

Issue 1235523003: Standardize parameters passed when Tabs are created asynchronously. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelSelector.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelSelector.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelSelector.java
index 2f7d2bc92f0051ed80b9a9400dd1f20f08742dbf..4769576a6aab0c3cc8ddfca193e47fbeff310744 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelSelector.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelSelector.java
@@ -12,17 +12,14 @@ import android.content.Context;
import android.content.SharedPreferences;
import android.net.Uri;
import android.os.Build;
-import android.util.SparseArray;
import org.chromium.base.ActivityState;
import org.chromium.base.ApplicationStatus;
import org.chromium.base.ApplicationStatus.ActivityStateListener;
-import org.chromium.base.ThreadUtils;
import org.chromium.base.VisibleForTesting;
import org.chromium.chrome.browser.Tab;
import org.chromium.chrome.browser.UrlConstants;
import org.chromium.chrome.browser.document.DocumentUtils;
-import org.chromium.chrome.browser.document.PendingDocumentData;
import org.chromium.chrome.browser.tab.TabIdManager;
import org.chromium.chrome.browser.tabmodel.OffTheRecordTabModel.OffTheRecordTabModelDelegate;
import org.chromium.chrome.browser.tabmodel.TabCreatorManager;
@@ -82,12 +79,6 @@ public class DocumentTabModelSelector extends TabModelSelectorBase
private final OffTheRecordDocumentTabModel mIncognitoTabModel;
/**
- * A map of tab IDs to PendingDocumentData to be consumed by opening activities.
- */
- private final SparseArray<PendingDocumentData> mPendingDocumentData =
- new SparseArray<PendingDocumentData>();
-
- /**
* If the TabModels haven't been initialized yet, prioritize the correct one to load the Tab.
* @param prioritizedTabId ID of the tab to prioritize.
*/
@@ -229,26 +220,6 @@ public class DocumentTabModelSelector extends TabModelSelectorBase
}
/**
- * Stores PendingUrlParams to be used when the tab with the given ID is launched via intent.
- * @param tabId The ID of the tab that will be launched via intent.
- * @param params The PendingUrlParams to use when loading the URL in the tab.
- */
- public void addPendingDocumentData(int tabId, PendingDocumentData params) {
- ThreadUtils.assertOnUiThread();
- mPendingDocumentData.put(tabId, params);
- }
-
- /**
- * @return Retrieves and removes PendingDocumentData for a particular tab id.
- */
- public PendingDocumentData removePendingDocumentData(int tabId) {
- ThreadUtils.assertOnUiThread();
- PendingDocumentData data = mPendingDocumentData.get(tabId);
- mPendingDocumentData.remove(tabId);
- return data;
- }
-
- /**
* Creates a data string which stores the base information we need to relaunch a task: a unique
* identifier and the URL to load.
* @param id ID of the tab in the DocumentActivity.

Powered by Google App Engine
This is Rietveld 408576698