chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeTestBase.java - Issue 1235523003: Standardize parameters passed when Tabs are created asynchronously.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeTestBase.java

Issue 1235523003: Standardize parameters passed when Tabs are created asynchronously. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/ChromeTabbedActivityLollipopAndAboveTest.java ('k') | chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeTestBase.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeTestBase.java b/chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeTestBase.java

index 6769d9e326bf9e1a8d2562636116868b895a10fc..5ee15b1d3ec884389a7daa7ed862f815ea694702 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeTestBase.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeTestBase.java

@@ -20,6 +20,7 @@ import org.chromium.chrome.browser.EmptyTabObserver;

import org.chromium.chrome.browser.IntentHandler;

import org.chromium.chrome.browser.Tab;

import org.chromium.chrome.browser.tabmodel.TabModel;

+import org.chromium.chrome.browser.tabmodel.document.AsyncTabCreationParams;

import org.chromium.chrome.browser.tabmodel.document.DocumentTabModelSelector;

import org.chromium.chrome.test.MultiActivityTestBase;

import org.chromium.chrome.test.util.ActivityUtils;

@@ -27,7 +28,7 @@ import org.chromium.chrome.test.util.DisableInTabbedMode;

import org.chromium.content.browser.test.util.Criteria;

import org.chromium.content.browser.test.util.CriteriaHelper;

import org.chromium.content.browser.test.util.TouchCommon;

-import org.chromium.ui.base.PageTransition;

+import org.chromium.content_public.browser.LoadUrlParams;

import java.util.concurrent.Callable;

@@ -132,9 +133,9 @@ public class DocumentModeTestBase extends MultiActivityTestBase {

Runnable runnable = new Runnable() {

@Override

public void run() {

- ChromeLauncherActivity.launchDocumentInstance(null, incognito,

- ChromeLauncherActivity.LAUNCH_MODE_FOREGROUND, url,

- DocumentMetricIds.STARTED_BY_UNKNOWN, PageTransition.LINK, null);

+ AsyncTabCreationParams asyncParams =

+ new AsyncTabCreationParams(new LoadUrlParams(url));

+ ChromeLauncherActivity.launchDocumentInstance(null, incognito, asyncParams);

}

};

return launchUrlViaRunnable(incognito, runnable, expectedTitle);