Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1235203003: WIP cc: remove unused and legacy GetMappedMemoryLimit code. (Closed)

Created:
5 years, 5 months ago by dshwang
Modified:
5 years, 5 months ago
Reviewers:
danakj, piman
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, James Su, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: remove unused and legacy GetMappedMemoryLimit code. Mapped memory is managed by MappedMemoryManager in GLES2Implementation. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -125 lines) Patch
M cc/output/context_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/context_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/test/test_context_provider.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/test/test_context_provider.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M cc/test/test_web_graphics_context_3d.h View 1 chunk +0 lines, -5 lines 0 comments Download
M cc/test/test_web_graphics_context_3d.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M content/browser/android/in_process/context_provider_in_process.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/common/gpu/client/context_provider_command_buffer.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/blink/webgraphicscontext3d_in_process_command_buffer_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/blink/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/client/gl_in_process_context.h View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gl_in_process_context.cc View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
dshwang
danakj, could you review cc/ ? piman, could you review content/ and gpu/ ?
5 years, 5 months ago (2015-07-14 16:40:04 UTC) #2
dshwang
5 years, 5 months ago (2015-07-14 17:33:06 UTC) #3 
On 2015/07/14 16:40:04, dshwang wrote:
> danakj, could you review cc/ ?
> piman, could you review content/ and gpu/ ?

sorry for noise. it depends on https://codereview.chromium.org/1227163017
After landing the CL, I'll request to review again.

Powered by Google App Engine
This is Rietveld 408576698