Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1227163017: cc: one copy is default as well as final fallback. (Closed)

Created:
5 years, 5 months ago by dshwang
Modified:
5 years, 5 months ago
Reviewers:
reveman
CC:
cc-bugs_chromium.org, chromium-reviews, creis+watch_chromium.org, danakj+watch_chromium.org, darin-cc_chromium.org, davemoore+watch_chromium.org, dzhioev+watch_chromium.org, jam, jbauman+watch_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, sievers+watch_chromium.org, stevenjb+watch_chromium.org, Ian Vollick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: one copy is default as well as final fallback. TODO: remove PixelBufferTileTaskWorkerPool BUG=435565 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Patch Set 1 #

Patch Set 2 : build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -129 lines) Patch
M cc/layers/picture_layer_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/scrollbar_layer_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 3 chunks +14 lines, -57 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_synchronous.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_pixeltest_tiles.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 4 chunks +0 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 4 chunks +0 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_settings.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/html_viewer/web_layer_tree_view_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/gpu/compositor_util.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/gpu/compositor_util.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/gpu/compositor_dependencies.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M content/test/fake_compositor_dependencies.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/fake_compositor_dependencies.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/compositor/compositor.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/compositor_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/compositor_switches.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
dshwang
reveman, could you review? If you agree and land it, I'll remove PixelBufferTileTaskWorkerPool in next ...
5 years, 5 months ago (2015-07-14 17:38:13 UTC) #2
reveman
I already have a patch (https://codereview.chromium.org/1186393004) that provides a more complete removal of async uploads ...
5 years, 5 months ago (2015-07-14 18:11:27 UTC) #3
dshwang
5 years, 5 months ago (2015-07-14 19:06:10 UTC) #4 
On 2015/07/14 18:11:27, reveman wrote:
> I already have a patch (https://codereview.chromium.org/1186393004) that
> provides a more complete removal of async uploads that I'll land when I think
> we're ready to remove that code.

ok, thx for noting. I close it as WontFix

Powered by Google App Engine
This is Rietveld 408576698