Update SplitString calls in components

Update SplitString calls in components

This converts calls from the old form to the new form. Some calls that iterated over the results were changed to a range-based for loop with an inline call to SplitString. Some places were changed to use StringPieces when it was safe to do so.

Committed: https://crrev.com/8be197d144c267c6a7c1b207a41267ac6c971712
Cr-Commit-Position: refs/heads/master@{#340209}

[brettw, 2015-07-18 06:01:02]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-18 06:01:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1234973004/1

[commit-bot: I haz the power, 2015-07-18 06:15:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-18 06:15:53]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[brettw, 2015-07-18 15:25:34]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-18 15:25:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1234973004/20001

[commit-bot: I haz the power, 2015-07-18 15:34:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-18 15:34:54]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-07-19 20:34:29]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-19 20:34:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1234973004/40001

[commit-bot: I haz the power, 2015-07-19 20:45:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-19 20:45:27]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-07-19 21:30:00]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-19 21:30:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1234973004/60001

[commit-bot: I haz the power, 2015-07-19 22:55:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-19 22:55:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-07-20 05:17:20]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-20 05:17:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1234973004/60001

[commit-bot: I haz the power, 2015-07-20 06:40:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-20 06:40:39]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-07-20 15:41:22]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-20 15:41:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1234973004/60001

[brettw, 2015-07-20 15:47:33]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-20 15:48:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1234973004/80001

[commit-bot: I haz the power, 2015-07-20 16:36:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-20 16:36:17]

Dry run: This issue passed the CQ dry run.

[brettw, 2015-07-20 17:57:09]

brettw@chromium.org changed reviewers:
+ jam@chromium.org

[brettw, 2015-07-20 17:57:09]

Weekend project part 1/2

[brettw, 2015-07-21 19:12:20]

brettw@chromium.org changed reviewers:
+ yzshen@chromium.org
- jam@chromium.org

[brettw, 2015-07-21 19:12:20]

Sorry!

[brettw, 2015-07-22 22:08:15]

ping?

[yzshen1, 2015-07-22 22:38:23]

I just reviewed till autofill_field.cc.

https://codereview.chromium.org/1234973004/diff/80001/components/autofill/cor...
File components/autofill/core/browser/address.cc (right):

https://codereview.chromium.org/1234973004/diff/80001/components/autofill/cor...
components/autofill/core/browser/address.cc:135: base::KEEP_WHITESPACE,
base::SPLIT_WANT_ALL);
should this be TRIM_WHITESPACE?

https://codereview.chromium.org/1234973004/diff/80001/components/autofill/cor...
File components/autofill/core/browser/address_i18n.cc (right):

https://codereview.chromium.org/1234973004/diff/80001/components/autofill/cor...
components/autofill/core/browser/address_i18n.cc:54: "\n",
base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL);
TRIM_WHITESPACE?

https://codereview.chromium.org/1234973004/diff/80001/components/autofill/cor...
File components/autofill/core/browser/autofill_field.cc (right):

https://codereview.chromium.org/1234973004/diff/80001/components/autofill/cor...
components/autofill/core/browser/autofill_field.cc:342: base::KEEP_WHITESPACE,
base::SPLIT_WANT_ALL);
TRIM_WHITESPACE

https://codereview.chromium.org/1234973004/diff/80001/components/autofill/cor...
components/autofill/core/browser/autofill_field.cc:375: base::KEEP_WHITESPACE,
base::SPLIT_WANT_ALL);
TRIM_WHITESPACE

[yzshen1, 2015-07-22 22:50:34]

I have reviewed till network_metrics_provider.cc and realized that almost
everywere KEEP_WHITESPACE is used instead of TRIM_WHITESPACE. I sampled some of
the remaining files and found the same thing.

If all these are intentional, then LGTM. :)

https://codereview.chromium.org/1234973004/diff/80001/components/autofill/cor...
File components/autofill/core/browser/credit_card.cc (right):

https://codereview.chromium.org/1234973004/diff/80001/components/autofill/cor...
components/autofill/core/browser/credit_card.cc:453: base::KEEP_WHITESPACE,
base::SPLIT_WANT_ALL);
TRIM_WHITESPACE

https://codereview.chromium.org/1234973004/diff/80001/components/bookmarks/br...
File components/bookmarks/browser/bookmark_index_unittest.cc (right):

https://codereview.chromium.org/1234973004/diff/80001/components/bookmarks/br...
components/bookmarks/browser/bookmark_index_unittest.cc:114:
base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL)) {
TRIM_WHITESPACE

https://codereview.chromium.org/1234973004/diff/80001/components/bookmarks/br...
components/bookmarks/browser/bookmark_index_unittest.cc:116: match, ",",
base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL);
TRIM_WHITESPACE

https://codereview.chromium.org/1234973004/diff/80001/components/bookmarks/br...
components/bookmarks/browser/bookmark_index_unittest.cc:198:
base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL)) {
TRIM_WHITESPACE

https://codereview.chromium.org/1234973004/diff/80001/components/bookmarks/br...
components/bookmarks/browser/bookmark_index_unittest.cc:207:
base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL);
TRIM_WHITESPACE

https://codereview.chromium.org/1234973004/diff/80001/components/bookmarks/br...
components/bookmarks/browser/bookmark_index_unittest.cc:259:
base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL)) {
TRIM_WHITESPACE

https://codereview.chromium.org/1234973004/diff/80001/components/bookmarks/br...
components/bookmarks/browser/bookmark_index_unittest.cc:268:
base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL);
TRIM_WHITESPACE

https://codereview.chromium.org/1234973004/diff/80001/components/content_sett...
File components/content_settings/core/browser/content_settings_utils.cc (right):

https://codereview.chromium.org/1234973004/diff/80001/components/content_sett...
components/content_settings/core/browser/content_settings_utils.cc:117:
base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL);
TRIM_WHITESPACE

https://codereview.chromium.org/1234973004/diff/80001/components/content_sett...
File components/content_settings/core/common/content_settings_pattern.cc
(right):

https://codereview.chromium.org/1234973004/diff/80001/components/content_sett...
components/content_settings/core/common/content_settings_pattern.cc:51: str1,
".", base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL);
TRIM_WHITESPACE

https://codereview.chromium.org/1234973004/diff/80001/components/content_sett...
components/content_settings/core/common/content_settings_pattern.cc:53: str2,
".", base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL);
TRIM_WHITESPACE

https://codereview.chromium.org/1234973004/diff/80001/components/data_reducti...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.cc
(right):

https://codereview.chromium.org/1234973004/diff/80001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.cc:91:
session_key, "|", base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL);
TRIM_WHITESPACE

https://codereview.chromium.org/1234973004/diff/80001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.cc:149:
version, ".", base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL);
TRIM_WHITESPACE

https://codereview.chromium.org/1234973004/diff/80001/components/device_event...
File components/device_event_log/device_event_log_impl_unittest.cc (right):

https://codereview.chromium.org/1234973004/diff/80001/components/device_event...
components/device_event_log/device_event_log_impl_unittest.cc:57: input, "\n",
base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL)) {
TRIM_WHITESPACE

https://codereview.chromium.org/1234973004/diff/80001/components/dom_distille...
File components/dom_distiller/standalone/content_extractor_browsertest.cc
(right):

https://codereview.chromium.org/1234973004/diff/80001/components/dom_distille...
components/dom_distiller/standalone/content_extractor_browsertest.cc:252:
urls_string, " ", base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL);
TRIM_WHITESPACE

https://codereview.chromium.org/1234973004/diff/80001/components/dom_distille...
components/dom_distiller/standalone/content_extractor_browsertest.cc:262:
base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL);
TRIM_WHITESPACE

https://codereview.chromium.org/1234973004/diff/80001/components/metrics/net/...
File components/metrics/net/network_metrics_provider.cc (right):

https://codereview.chromium.org/1234973004/diff/80001/components/metrics/net/...
components/metrics/net/network_metrics_provider.cc:230: info.oui_list, " ",
base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL)) {
TRIM_WHITESPACE

[brettw, 2015-07-23 00:25:02]

Gargh, I messed up my copy-and-paste macro and ended up with a bunch of those
KEEP_ calls :( Thanks for catching that.

[brettw, 2015-07-23 21:53:16]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-23 21:53:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1234973004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1234973004/100001

[brettw, 2015-07-23 21:53:44]

New snap up. I audited the existing calls and converted most KEEP->TRIM. Take
another look if you want, but don't feel obligated.

[yzshen1, 2015-07-23 22:20:01]

On 2015/07/23 21:53:44, brettw wrote:
> New snap up. I audited the existing calls and converted most KEEP->TRIM. Take
> another look if you want, but don't feel obligated.

rubberstamp LGTM

Thanks!

[commit-bot: I haz the power, 2015-07-23 23:15:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-23 23:15:37]

Dry run: This issue passed the CQ dry run.

[brettw, 2015-07-23 23:16:18]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-07-23 23:16:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1234973004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1234973004/100001

[commit-bot: I haz the power, 2015-07-23 23:23:54]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-07-23 23:25:12]

Patchset 6 (id:??) landed as
https://crrev.com/8be197d144c267c6a7c1b207a41267ac6c971712
Cr-Commit-Position: refs/heads/master@{#340209}

[brettw, 2015-07-31 23:51:40]

LGTM, thanks!