components/query_parser/snippet.cc - Issue 1234973004: Update SplitString calls in components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/query_parser/snippet.cc

Issue 1234973004: Update SplitString calls in components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixes Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/query_parser/snippet.cc

diff --git a/components/query_parser/snippet.cc b/components/query_parser/snippet.cc

index e393d60ff089ea6280eb555fb4a74078061c4393..2276e4acc772eb2d2b9986799fff7cf1d2e92e1a 100644

--- a/components/query_parser/snippet.cc

+++ b/components/query_parser/snippet.cc

@@ -167,8 +167,8 @@ void Snippet::ExtractMatchPositions(const std::string& offsets_str,

DCHECK(match_positions);

if (offsets_str.empty())

return;

- std::vector<std::string> offsets;

- base::SplitString(offsets_str, ' ', &offsets);

+ std::vector<std::string> offsets = base::SplitString(

+ offsets_str, " ", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);

// SQLite offsets are sets of four integers:

// column, query term, match offset, match length

// Matches within a string are marked by (start, end) pairs.