components/nacl/zygote/nacl_fork_delegate_linux.cc - Issue 1234973004: Update SplitString calls in components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/zygote/nacl_fork_delegate_linux.cc

Issue 1234973004: Update SplitString calls in components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixes Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/nacl/zygote/nacl_fork_delegate_linux.cc

diff --git a/components/nacl/zygote/nacl_fork_delegate_linux.cc b/components/nacl/zygote/nacl_fork_delegate_linux.cc

index 12d265c37b89d05aae5ccd2bbeacf92b44d38786..ae625643171ab6304bfcc2b0aafdbd7251b4657d 100644

--- a/components/nacl/zygote/nacl_fork_delegate_linux.cc

+++ b/components/nacl/zygote/nacl_fork_delegate_linux.cc

@@ -447,8 +447,9 @@ void NaClForkDelegate::AddPassthroughEnvToOptions(

std::string pass_through_string;

std::vector<std::string> pass_through_vars;

if (env->GetVar(kNaClEnvPassthrough, &pass_through_string)) {

- base::SplitString(

- pass_through_string, kNaClEnvPassthroughDelimiter, &pass_through_vars);

+ pass_through_vars = base::SplitString(

+ pass_through_string, std::string(1, kNaClEnvPassthroughDelimiter),

+ base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);

}

pass_through_vars.push_back(kNaClExeStderr);

pass_through_vars.push_back(kNaClExeStdout);