Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Unified Diff: components/search_engines/default_search_pref_test_util.cc

Issue 1234973004: Update SplitString calls in components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/search_engines/default_search_pref_test_util.cc
diff --git a/components/search_engines/default_search_pref_test_util.cc b/components/search_engines/default_search_pref_test_util.cc
index f09add350e453ab208a1025dd0d07d43a732422b..22acd425b39a86b388911d82daaff49053f89cc1 100644
--- a/components/search_engines/default_search_pref_test_util.cc
+++ b/components/search_engines/default_search_pref_test_util.cc
@@ -41,14 +41,10 @@ DefaultSearchPrefTestUtil::CreateDefaultSearchPreferenceValue(
value->Set(DefaultSearchManager::kSearchTermsReplacementKey,
new base::StringValue(search_terms_replacement_key));
- std::vector<std::string> encodings_items;
- base::SplitString(encodings, ';', &encodings_items);
scoped_ptr<base::ListValue> encodings_list(new base::ListValue);
- for (std::vector<std::string>::const_iterator it = encodings_items.begin();
- it != encodings_items.end();
- ++it) {
- encodings_list->AppendString(*it);
- }
+ for (const std::string& term : base::SplitString(
+ encodings, ";", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL))
+ encodings_list->AppendString(term);
value->Set(DefaultSearchManager::kInputEncodings, encodings_list.release());
scoped_ptr<base::ListValue> alternate_url_list(new base::ListValue());
« no previous file with comments | « components/search_engines/default_search_pref_migration.cc ('k') | components/search_engines/keyword_table.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698