Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Side by Side Diff: components/search_engines/default_search_manager_unittest.cc

Issue 1234973004: Update SplitString calls in components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/files/scoped_temp_dir.h" 5 #include "base/files/scoped_temp_dir.h"
6 #include "base/memory/scoped_ptr.h" 6 #include "base/memory/scoped_ptr.h"
7 #include "base/strings/string_split.h" 7 #include "base/strings/string_split.h"
8 #include "base/strings/string_util.h" 8 #include "base/strings/string_util.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "base/time/time.h" 10 #include "base/time/time.h"
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 scoped_ptr<TemplateURLData> data(new TemplateURLData()); 122 scoped_ptr<TemplateURLData> data(new TemplateURLData());
123 data->SetShortName(base::UTF8ToUTF16(std::string(type).append("name"))); 123 data->SetShortName(base::UTF8ToUTF16(std::string(type).append("name")));
124 data->SetKeyword(base::UTF8ToUTF16(std::string(type).append("key"))); 124 data->SetKeyword(base::UTF8ToUTF16(std::string(type).append("key")));
125 data->SetURL(std::string("http://").append(type).append("foo/{searchTerms}")); 125 data->SetURL(std::string("http://").append(type).append("foo/{searchTerms}"));
126 data->suggestions_url = std::string("http://").append(type).append("sugg"); 126 data->suggestions_url = std::string("http://").append(type).append("sugg");
127 data->alternate_urls.push_back( 127 data->alternate_urls.push_back(
128 std::string("http://").append(type).append("foo/alt")); 128 std::string("http://").append(type).append("foo/alt"));
129 data->favicon_url = GURL("http://icon1"); 129 data->favicon_url = GURL("http://icon1");
130 data->safe_for_autoreplace = true; 130 data->safe_for_autoreplace = true;
131 data->show_in_default_list = true; 131 data->show_in_default_list = true;
132 base::SplitString("UTF-8;UTF-16", ';', &data->input_encodings); 132 data->input_encodings = base::SplitString(
133 "UTF-8;UTF-16", ";", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
133 data->date_created = base::Time(); 134 data->date_created = base::Time();
134 data->last_modified = base::Time(); 135 data->last_modified = base::Time();
135 return data.Pass(); 136 return data.Pass();
136 } 137 }
137 138
138 } // namespace 139 } // namespace
139 140
140 class DefaultSearchManagerTest : public testing::Test { 141 class DefaultSearchManagerTest : public testing::Test {
141 public: 142 public:
142 DefaultSearchManagerTest() {}; 143 DefaultSearchManagerTest() {};
(...skipping 20 matching lines...) Expand all
163 DefaultSearchManager::ObserverCallback()); 164 DefaultSearchManager::ObserverCallback());
164 TemplateURLData data; 165 TemplateURLData data;
165 data.SetShortName(base::UTF8ToUTF16("name1")); 166 data.SetShortName(base::UTF8ToUTF16("name1"));
166 data.SetKeyword(base::UTF8ToUTF16("key1")); 167 data.SetKeyword(base::UTF8ToUTF16("key1"));
167 data.SetURL("http://foo1/{searchTerms}"); 168 data.SetURL("http://foo1/{searchTerms}");
168 data.suggestions_url = "http://sugg1"; 169 data.suggestions_url = "http://sugg1";
169 data.alternate_urls.push_back("http://foo1/alt"); 170 data.alternate_urls.push_back("http://foo1/alt");
170 data.favicon_url = GURL("http://icon1"); 171 data.favicon_url = GURL("http://icon1");
171 data.safe_for_autoreplace = true; 172 data.safe_for_autoreplace = true;
172 data.show_in_default_list = true; 173 data.show_in_default_list = true;
173 base::SplitString("UTF-8;UTF-16", ';', &data.input_encodings); 174 data.input_encodings = base::SplitString(
175 "UTF-8;UTF-16", ";", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
174 data.date_created = base::Time(); 176 data.date_created = base::Time();
175 data.last_modified = base::Time(); 177 data.last_modified = base::Time();
176 178
177 manager.SetUserSelectedDefaultSearchEngine(data); 179 manager.SetUserSelectedDefaultSearchEngine(data);
178 TemplateURLData* read_data = manager.GetDefaultSearchEngine(NULL); 180 TemplateURLData* read_data = manager.GetDefaultSearchEngine(NULL);
179 ExpectSimilar(&data, read_data); 181 ExpectSimilar(&data, read_data);
180 } 182 }
181 183
182 // Test DefaultSearchmanager handles user-selected DSEs correctly. 184 // Test DefaultSearchmanager handles user-selected DSEs correctly.
183 TEST_F(DefaultSearchManagerTest, DefaultSearchSetByUserPref) { 185 TEST_F(DefaultSearchManagerTest, DefaultSearchSetByUserPref) {
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
315 317
316 ExpectSimilar(extension_data_3.get(), 318 ExpectSimilar(extension_data_3.get(),
317 manager.GetDefaultSearchEngine(&source)); 319 manager.GetDefaultSearchEngine(&source));
318 EXPECT_EQ(DefaultSearchManager::FROM_EXTENSION, source); 320 EXPECT_EQ(DefaultSearchManager::FROM_EXTENSION, source);
319 321
320 manager.ClearExtensionControlledDefaultSearchEngine(); 322 manager.ClearExtensionControlledDefaultSearchEngine();
321 323
322 ExpectSimilar(data.get(), manager.GetDefaultSearchEngine(&source)); 324 ExpectSimilar(data.get(), manager.GetDefaultSearchEngine(&source));
323 EXPECT_EQ(DefaultSearchManager::FROM_USER, source); 325 EXPECT_EQ(DefaultSearchManager::FROM_USER, source);
324 } 326 }
OLDNEW
« no previous file with comments | « components/query_parser/snippet_unittest.cc ('k') | components/search_engines/default_search_pref_migration.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698