components/translate/core/common/translate_util.cc - Issue 1234973004: Update SplitString calls in components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/core/common/translate_util.cc

Issue 1234973004: Update SplitString calls in components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixes Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/translate/core/common/translate_util.cc

diff --git a/components/translate/core/common/translate_util.cc b/components/translate/core/common/translate_util.cc

index 35c54a9249b6073b30c30ac1a25bfd0e7a8ab1cb..37d6a3ed48d8c05b6100f86398009765c32ae072 100644

--- a/components/translate/core/common/translate_util.cc

+++ b/components/translate/core/common/translate_util.cc

@@ -21,12 +21,12 @@ void SplitIntoMainAndTail(const std::string& language,

DCHECK(main_part);

DCHECK(tail_part);

- std::vector<std::string> chunks;

- base::SplitString(language, '-', &chunks);

- if (chunks.size() == 0u)

+ std::vector<base::StringPiece> chunks = base::SplitStringPiece(

+ language, "-", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);

+ if (chunks.empty())

return;

- *main_part = chunks[0];

+ chunks[0].CopyToString(main_part);

*tail_part = language.substr(main_part->size());

}