Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1230813003: More threading of GrProcessorDataManager (Closed)

Created:
5 years, 5 months ago by joshua.litt
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -185 lines) Patch
M gm/texturedomaineffect.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M include/gpu/GrContext.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/core/SkBitmapProcShader.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 3 chunks +3 lines, -1 line 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 16 chunks +49 lines, -33 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 7 chunks +12 lines, -6 lines 0 comments Download
M src/effects/SkMatrixConvolutionImageFilter.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 6 chunks +21 lines, -15 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrBlurUtils.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M src/gpu/GrContext.cpp View 9 chunks +18 lines, -10 lines 0 comments Download
M src/gpu/GrPaint.cpp View 1 chunk +8 lines, -4 lines 0 comments Download
M src/gpu/GrPipelineBuilder.h View 1 chunk +8 lines, -4 lines 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 3 chunks +13 lines, -7 lines 0 comments Download
M src/gpu/effects/Gr1DKernelEffect.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.h View 3 chunks +19 lines, -16 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.cpp View 2 chunks +9 lines, -6 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.h View 2 chunks +7 lines, -6 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 7 chunks +22 lines, -15 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.h View 3 chunks +12 lines, -6 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 3 chunks +8 lines, -5 lines 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.h View 4 chunks +8 lines, -4 lines 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.cpp View 5 chunks +9 lines, -5 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.h View 2 chunks +17 lines, -11 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/effects/GrSingleTextureEffect.h View 1 chunk +6 lines, -3 lines 0 comments Download
M src/gpu/effects/GrSingleTextureEffect.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 4 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
joshualitt
ptal
5 years, 5 months ago (2015-07-09 15:43:53 UTC) #2
robertphillips
lgtm + nits https://codereview.chromium.org/1230813003/diff/1/src/effects/SkLightingImageFilter.cpp File src/effects/SkLightingImageFilter.cpp (right): https://codereview.chromium.org/1230813003/diff/1/src/effects/SkLightingImageFilter.cpp#newcode1234 src/effects/SkLightingImageFilter.cpp:1234: #if SK_SUPPORT_GPU I think the preference ...
5 years, 5 months ago (2015-07-09 16:11:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230813003/20001
5 years, 5 months ago (2015-07-09 16:21:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230813003/20001
5 years, 5 months ago (2015-07-09 16:22:04 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 17:24:40 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5f10b5c1b5744106312e24835d235b72fdba5802

Powered by Google App Engine
This is Rietveld 408576698