Extract duplicated code in browser_tests for closing a browser.

Extract duplicated code in browser_tests for closing a browser.

There is a lot of duplicated code, and much of it only partially duplicated (and
hence incorrect). Pull it out into the common methods
CloseBrowserSynchronously(), CloseBrowserAsynchronously() and
CloseAllBrowsers(). This fixes many Mac tests on Yosemite.

BUG=445495
Committed: https://crrev.com/64a6d4440f3ac8fbca44de888406da881a0f4bd1
Cr-Commit-Position: refs/heads/master@{#338340}

[erikchen, 2015-07-08 22:05:43]

erikchen@chromium.org changed reviewers:
+ rsesek@chromium.org

[erikchen, 2015-07-08 22:05:44]

rsesek: Please review.

https://codereview.chromium.org/1228723002/diff/20001/chrome/test/base/in_pro...
File chrome/test/base/in_process_browser_test.h (right):

https://codereview.chromium.org/1228723002/diff/20001/chrome/test/base/in_pro...
chrome/test/base/in_process_browser_test.h:116: // outstanding resources.
There is only one caller of this method, and I just replicated its code, with
the addition of the autoreleasepool drain.

[Robert Sesek, 2015-07-08 22:19:37]

LGTM but not an OWNER

https://codereview.chromium.org/1228723002/diff/20001/chrome/test/base/in_pro...
File chrome/test/base/in_process_browser_test.cc (right):

https://codereview.chromium.org/1228723002/diff/20001/chrome/test/base/in_pro...
chrome/test/base/in_process_browser_test.cc:384:
content::NotificationService::AllSources());
May want to limit this to just the |browser| Source.

[erikchen, 2015-07-08 22:25:10]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[erikchen, 2015-07-08 22:25:10]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/1228723002/#ps40001
(title: "Comments from rsesek.")

[commit-bot: I haz the power, 2015-07-08 22:27:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1228723002/40001

[commit-bot: I haz the power, 2015-07-08 23:10:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-08 23:10:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

(exceeded global retry quota)

[erikchen, 2015-07-09 00:40:50]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[erikchen, 2015-07-09 00:40:51]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/1228723002/#ps80001
(title: "Fix ProfileManagerBrowserTest.EphemeralProfile.")

[erikchen, 2015-07-09 00:41:13]

rsesek: PTAL

Some minor test fixes and API changes.

[commit-bot: I haz the power, 2015-07-09 00:41:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1228723002/80001

[commit-bot: I haz the power, 2015-07-09 00:59:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

(exceeded global retry quota)

[erikchen, 2015-07-09 01:12:12]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[erikchen, 2015-07-09 01:12:12]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/1228723002/#ps120001
(title: "Change a method name to prevent collisions.")

[commit-bot: I haz the power, 2015-07-09 01:13:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1228723002/120001

[commit-bot: I haz the power, 2015-07-09 02:01:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-09 02:01:32]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

(exceeded global retry quota)

[erikchen, 2015-07-09 06:57:14]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[erikchen, 2015-07-09 06:57:15]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/1228723002/#ps140001
(title: "Fix bug on Linux/Win.")

[commit-bot: I haz the power, 2015-07-09 06:57:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1228723002/140001

[commit-bot: I haz the power, 2015-07-09 07:37:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-09 07:37:18]

Dry run: This issue passed the CQ dry run.

[Robert Sesek, 2015-07-09 15:07:05]

https://codereview.chromium.org/1228723002/diff/140001/chrome/test/base/in_pr...
File chrome/test/base/in_process_browser_test.h (right):

https://codereview.chromium.org/1228723002/diff/140001/chrome/test/base/in_pr...
chrome/test/base/in_process_browser_test.h:120: void
CloseBrowserWithoutWaiting(Browser* browser);
Why "WithoutWaiting" instead of "Asynchronously" ?

[erikchen, 2015-07-09 23:35:43]

https://codereview.chromium.org/1228723002/diff/140001/chrome/test/base/in_pr...
File chrome/test/base/in_process_browser_test.h (right):

https://codereview.chromium.org/1228723002/diff/140001/chrome/test/base/in_pr...
chrome/test/base/in_process_browser_test.h:120: void
CloseBrowserWithoutWaiting(Browser* browser);
On 2015/07/09 15:07:05, Robert Sesek wrote:
> Why "WithoutWaiting" instead of "Asynchronously" ?

I plead the fifth. Changed the name to CloseBrowserAsynchronously

[erikchen, 2015-07-09 23:38:53]

erikchen@chromium.org changed reviewers:
+ jhawkins@chromium.org

[erikchen, 2015-07-09 23:38:54]

jhawkins: Looking for an OWNER review of chrome/

[James Hawkins, 2015-07-10 18:01:26]

lgtm

[erikchen, 2015-07-10 18:10:29]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2015-07-10 18:10:29]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/1228723002/#ps160001
(title: "s/WithoutWaiting/Asynchronously")

[commit-bot: I haz the power, 2015-07-10 18:11:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1228723002/160001

[commit-bot: I haz the power, 2015-07-10 19:38:27]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2015-07-10 19:39:27]

Patchset 9 (id:??) landed as
https://crrev.com/64a6d4440f3ac8fbca44de888406da881a0f4bd1
Cr-Commit-Position: refs/heads/master@{#338340}