Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Side by Side Diff: chrome/browser/sessions/session_restore_browsertest.cc

Issue 1228723002: Extract duplicated code in browser_tests for closing a browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: s/WithoutWaiting/Asynchronously Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <vector> 5 #include <vector>
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/files/file_path.h" 8 #include "base/files/file_path.h"
9 #include "base/memory/memory_pressure_listener.h" 9 #include "base/memory/memory_pressure_listener.h"
10 #include "base/process/launch.h" 10 #include "base/process/launch.h"
11 #include "base/strings/utf_string_conversions.h" 11 #include "base/strings/utf_string_conversions.h"
12 #include "base/time/time.h" 12 #include "base/time/time.h"
13 #include "chrome/browser/browser_process.h" 13 #include "chrome/browser/browser_process.h"
14 #include "chrome/browser/chrome_notification_types.h"
15 #include "chrome/browser/defaults.h" 14 #include "chrome/browser/defaults.h"
16 #include "chrome/browser/first_run/first_run.h" 15 #include "chrome/browser/first_run/first_run.h"
17 #include "chrome/browser/profiles/profile.h" 16 #include "chrome/browser/profiles/profile.h"
18 #include "chrome/browser/profiles/profile_manager.h" 17 #include "chrome/browser/profiles/profile_manager.h"
19 #include "chrome/browser/sessions/session_restore.h" 18 #include "chrome/browser/sessions/session_restore.h"
20 #include "chrome/browser/sessions/session_restore_test_helper.h" 19 #include "chrome/browser/sessions/session_restore_test_helper.h"
21 #include "chrome/browser/sessions/session_service.h" 20 #include "chrome/browser/sessions/session_service.h"
22 #include "chrome/browser/sessions/session_service_factory.h" 21 #include "chrome/browser/sessions/session_service_factory.h"
23 #include "chrome/browser/sessions/session_service_test_helper.h" 22 #include "chrome/browser/sessions/session_service_test_helper.h"
24 #include "chrome/browser/sessions/tab_restore_service.h" 23 #include "chrome/browser/sessions/tab_restore_service.h"
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 url2_ = ui_test_utils::GetTestUrl( 101 url2_ = ui_test_utils::GetTestUrl(
103 base::FilePath().AppendASCII("session_history"), 102 base::FilePath().AppendASCII("session_history"),
104 base::FilePath().AppendASCII("bot2.html")); 103 base::FilePath().AppendASCII("bot2.html"));
105 url3_ = ui_test_utils::GetTestUrl( 104 url3_ = ui_test_utils::GetTestUrl(
106 base::FilePath().AppendASCII("session_history"), 105 base::FilePath().AppendASCII("session_history"),
107 base::FilePath().AppendASCII("bot3.html")); 106 base::FilePath().AppendASCII("bot3.html"));
108 107
109 return InProcessBrowserTest::SetUpUserDataDirectory(); 108 return InProcessBrowserTest::SetUpUserDataDirectory();
110 } 109 }
111 110
112 void CloseBrowserSynchronously(Browser* browser) {
113 content::WindowedNotificationObserver observer(
114 chrome::NOTIFICATION_BROWSER_CLOSED,
115 content::NotificationService::AllSources());
116 browser->window()->Close();
117 #if defined(OS_MACOSX)
118 // BrowserWindowController depends on the auto release pool being recycled
119 // in the message loop to delete itself, which frees the Browser object
120 // which fires this event.
121 AutoreleasePool()->Recycle();
122 #endif
123 observer.Wait();
124 }
125
126 Browser* QuitBrowserAndRestore(Browser* browser, int expected_tab_count) { 111 Browser* QuitBrowserAndRestore(Browser* browser, int expected_tab_count) {
127 return QuitBrowserAndRestoreWithURL( 112 return QuitBrowserAndRestoreWithURL(
128 browser, expected_tab_count, GURL(), true); 113 browser, expected_tab_count, GURL(), true);
129 } 114 }
130 115
131 Browser* QuitBrowserAndRestoreWithURL(Browser* browser, 116 Browser* QuitBrowserAndRestoreWithURL(Browser* browser,
132 int expected_tab_count, 117 int expected_tab_count,
133 const GURL& url, 118 const GURL& url,
134 bool no_memory_pressure) { 119 bool no_memory_pressure) {
135 Profile* profile = browser->profile(); 120 Profile* profile = browser->profile();
(...skipping 1376 matching lines...) Expand 10 before | Expand all | Expand 10 after
1512 // correct order. 1497 // correct order.
1513 for (size_t i = 0; i < web_contents().size(); i++) { 1498 for (size_t i = 0; i < web_contents().size(); i++) {
1514 GURL expected_url = urls[activation_order2[num_tabs - i - 1]]; 1499 GURL expected_url = urls[activation_order2[num_tabs - i - 1]];
1515 ASSERT_EQ(expected_url, web_contents()[i]->GetLastCommittedURL()); 1500 ASSERT_EQ(expected_url, web_contents()[i]->GetLastCommittedURL());
1516 if (i > 0) { 1501 if (i > 0) {
1517 ASSERT_GT(web_contents()[i - 1]->GetLastActiveTime(), 1502 ASSERT_GT(web_contents()[i - 1]->GetLastActiveTime(),
1518 web_contents()[i]->GetLastActiveTime()); 1503 web_contents()[i]->GetLastActiveTime());
1519 } 1504 }
1520 } 1505 }
1521 } 1506 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698