chrome/browser/profiles/profile_manager_browsertest.cc - Issue 1228723002: Extract duplicated code in browser_tests for closing a browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profile_manager_browsertest.cc

Issue 1228723002: Extract duplicated code in browser_tests for closing a browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: s/WithoutWaiting/Asynchronously Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/app_background_page_apitest.cc ('k') | chrome/browser/sessions/better_session_restore_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profiles/profile_manager_browsertest.cc

diff --git a/chrome/browser/profiles/profile_manager_browsertest.cc b/chrome/browser/profiles/profile_manager_browsertest.cc

index 43df0d4b63a5b991c7590ceebb84d7e508e193be..51af357ac27cfbcc5abe8368e412eef510a1072c 100644

--- a/chrome/browser/profiles/profile_manager_browsertest.cc

+++ b/chrome/browser/profiles/profile_manager_browsertest.cc

@@ -413,14 +413,12 @@ IN_PROC_BROWSER_TEST_F(ProfileManagerBrowserTest, MAYBE_EphemeralProfile) {

EXPECT_EQ(path_profile2, browser_list->get(2)->profile()->GetPath());

// Closing the first window of the ephemeral profile should not delete it.

- browser_list->get(2)->window()->Close();

- content::RunAllPendingInMessageLoop();

+ CloseBrowserSynchronously(browser_list->get(2));

EXPECT_EQ(2U, browser_list->size());

EXPECT_EQ(initial_profile_count + 1, cache.GetNumberOfProfiles());

// The second should though.

- browser_list->get(1)->window()->Close();

- content::RunAllPendingInMessageLoop();

+ CloseBrowserSynchronously(browser_list->get(1));

EXPECT_EQ(1U, browser_list->size());

EXPECT_EQ(initial_profile_count, cache.GetNumberOfProfiles());

}