chrome/browser/ui/settings_window_manager_browsertest.cc - Issue 1228723002: Extract duplicated code in browser_tests for closing a browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/settings_window_manager_browsertest.cc

Issue 1228723002: Extract duplicated code in browser_tests for closing a browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: s/WithoutWaiting/Asynchronously Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sessions/session_restore_browsertest_chromeos.cc ('k') | chrome/browser/ui/startup/startup_browser_creator_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/settings_window_manager_browsertest.cc

diff --git a/chrome/browser/ui/settings_window_manager_browsertest.cc b/chrome/browser/ui/settings_window_manager_browsertest.cc

index a551457c76738a1fb4f2d61132807cfb34aa972e..6491ae22bf305e5a6f3726b41128dec75abb0dc4 100644

--- a/chrome/browser/ui/settings_window_manager_browsertest.cc

+++ b/chrome/browser/ui/settings_window_manager_browsertest.cc

@@ -8,7 +8,6 @@

#include "base/files/file_util.h"

#include "base/files/scoped_temp_dir.h"

#include "chrome/browser/browser_process.h"

-#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/profiles/profile_manager.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_finder.h"

@@ -95,14 +94,6 @@ class SettingsWindowManagerTest : public InProcessBrowserTest {

profile, GURL(chrome::kChromeUISettingsURL));

}

- void CloseBrowserSynchronously(Browser* browser) {

- content::WindowedNotificationObserver observer(

- chrome::NOTIFICATION_BROWSER_CLOSED,

- content::NotificationService::AllSources());

- browser->window()->Close();

- observer.Wait();

- }

void CloseNonDefaultBrowsers() {

std::list<Browser*> browsers_to_close;

for (chrome::BrowserIterator it; !it.done(); it.Next()) {