chrome/browser/sessions/session_restore_browsertest_chromeos.cc - Issue 1228723002: Extract duplicated code in browser_tests for closing a browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sessions/session_restore_browsertest_chromeos.cc

Issue 1228723002: Extract duplicated code in browser_tests for closing a browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: s/WithoutWaiting/Asynchronously Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sessions/session_restore_browsertest.cc ('k') | chrome/browser/ui/settings_window_manager_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sessions/session_restore_browsertest_chromeos.cc

diff --git a/chrome/browser/sessions/session_restore_browsertest_chromeos.cc b/chrome/browser/sessions/session_restore_browsertest_chromeos.cc

index b11a18ccfc669178a1da3115c9a3e3ba4f84d46c..98cccc623dc89f191ccd9a35118a053ff754816f 100644

--- a/chrome/browser/sessions/session_restore_browsertest_chromeos.cc

+++ b/chrome/browser/sessions/session_restore_browsertest_chromeos.cc

@@ -54,14 +54,6 @@ class SessionRestoreTestChromeOS : public InProcessBrowserTest {

return false;

}

- void CloseBrowserSynchronously(Browser* browser) {

- content::WindowedNotificationObserver observer(

- chrome::NOTIFICATION_BROWSER_CLOSED,

- content::NotificationService::AllSources());

- browser->window()->Close();

- observer.Wait();

- }

Browser::CreateParams CreateParamsForApp(const std::string name,

bool trusted) {

return Browser::CreateParams::CreateForApp(

« no previous file with comments | « chrome/browser/sessions/session_restore_browsertest.cc ('k') | chrome/browser/ui/settings_window_manager_browsertest.cc » ('j') | no next file with comments »