Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Unified Diff: chrome/browser/app_controller_mac_browsertest.mm

Issue 1228723002: Extract duplicated code in browser_tests for closing a browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: s/WithoutWaiting/Asynchronously Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/content_settings/content_settings_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/app_controller_mac_browsertest.mm
diff --git a/chrome/browser/app_controller_mac_browsertest.mm b/chrome/browser/app_controller_mac_browsertest.mm
index 288b24e4b7c7df1868c8b21eab57013206588a7c..f23b840ddbe0dd986bc05176aa0306b15ce79e0e 100644
--- a/chrome/browser/app_controller_mac_browsertest.mm
+++ b/chrome/browser/app_controller_mac_browsertest.mm
@@ -664,10 +664,9 @@ IN_PROC_BROWSER_TEST_F(AppControllerHandoffBrowserTest, TestHandoffURLs) {
BrowserList::GetInstance(chrome::GetActiveDesktop());
EXPECT_EQ(2u, active_browser_list->size());
- // Close the one and only tab for the second browser window.
+ // Close the second browser window (which only has 1 tab left).
Browser* browser2 = active_browser_list->get(1);
- CloseTab(browser2, 0);
- base::RunLoop().RunUntilIdle();
+ CloseBrowserSynchronously(browser2);
EXPECT_EQ(g_handoff_url, test_url2);
// The URLs of incognito windows should not be passed to Handoff.
« no previous file with comments | « no previous file | chrome/browser/content_settings/content_settings_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698