Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1429)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1227413007: Move ReplaceStringPlaceholders to base namespace. (Closed)

Created:
5 years, 5 months ago by brettw
Modified:
5 years, 5 months ago
Reviewers:
jam
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, extensions-reviews_chromium.org, Matt Giuca, tapted, tfarina, chromoting-reviews_chromium.org, jam, wfh+watch_chromium.org, darin-cc_chromium.org, grt+watch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, jshin+watch_chromium.org, pedrosimonetti+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@join
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ReplaceStringPlaceholders to base namespace. Removes most unnecessary base:: qualifications from string_util. Updates ReplaceStringPlaceholders implementation to use C++11 features for the loop iterators. TBR=jam@chromium.org Committed: https://crrev.com/0daa2d36e70f005e199c63a1985c961fad05f28c Cr-Commit-Position: refs/heads/master@{#338826}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -108 lines) Patch
M base/strings/string_util.h View 7 chunks +28 lines, -29 lines 0 comments Download
M base/strings/string_util.cc View 1 14 chunks +34 lines, -41 lines 0 comments Download
M chrome/browser/extensions/extension_storage_monitor.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/launcher_search/launcher_search_icon_image_loader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/l10n_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/l10n_util.mm View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/web_resource/promo_resource_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/google_chrome_distribution.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/l10n_string_util.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/installer/util/user_experiment.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/mac_helpers/infoplist_strings_util.mm View 1 chunk +2 lines, -3 lines 0 comments Download
M cloud_print/service/win/cloud_print_service.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/dom_distiller/core/viewer.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/test/history_unittest_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/blink_platform_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/test/render_view_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/app_window/app_window_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/bluetooth/bluetooth_private_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/renderer/i18n_custom_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/webui/shared_resources_data_source_ios.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/disconnect_window_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/base/l10n/l10n_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/webui/web_ui_util.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1230243005 Patch 20001

Messages

Total messages: 5 (1 generated)
brettw
This is the last string_util one!
5 years, 5 months ago (2015-07-15 02:48:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227413007/20001
5 years, 5 months ago (2015-07-15 05:30:21 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-15 06:43:42 UTC) #4
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 06:44:34 UTC) #5
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/0daa2d36e70f005e199c63a1985c961fad05f28c
Cr-Commit-Position: refs/heads/master@{#338826}

Powered by Google App Engine
This is Rietveld 408576698