extensions/renderer/i18n_custom_bindings.cc - Issue 1227413007: Move ReplaceStringPlaceholders to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/i18n_custom_bindings.cc

Issue 1227413007: Move ReplaceStringPlaceholders to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@join

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/i18n_custom_bindings.cc

diff --git a/extensions/renderer/i18n_custom_bindings.cc b/extensions/renderer/i18n_custom_bindings.cc

index b5b3a4d60bb6fdd4eb975614688d9b72bd4b56d2..cf91030ee8ea33bc8bb8b054c67754d6353b5a71 100644

--- a/extensions/renderer/i18n_custom_bindings.cc

+++ b/extensions/renderer/i18n_custom_bindings.cc

@@ -81,7 +81,7 @@ void I18NCustomBindings::GetL10nMessage(

args.GetReturnValue().Set(v8::String::NewFromUtf8(

isolate,

- ReplaceStringPlaceholders(message, substitutions, NULL).c_str()));

+ base::ReplaceStringPlaceholders(message, substitutions, NULL).c_str()));

}

void I18NCustomBindings::GetL10nUILanguage(