extensions/browser/api/app_window/app_window_api.cc - Issue 1227413007: Move ReplaceStringPlaceholders to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/app_window/app_window_api.cc

Issue 1227413007: Move ReplaceStringPlaceholders to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@join

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/app_window/app_window_api.cc

diff --git a/extensions/browser/api/app_window/app_window_api.cc b/extensions/browser/api/app_window/app_window_api.cc

index fcc59610400d52635161d3f6765616c5d5361b95..313568ac35d07d64cee5feeb32fda0614590f9cc 100644

--- a/extensions/browser/api/app_window/app_window_api.cc

+++ b/extensions/browser/api/app_window/app_window_api.cc

@@ -86,7 +86,7 @@ bool CheckBoundsConflict(const scoped_ptr<int>& inner_property,

if (inner_property.get() && outer_property.get()) {

std::vector<std::string> subst;

subst.push_back(property_name);

- *error = ReplaceStringPlaceholders(

+ *error = base::ReplaceStringPlaceholders(

app_window_constants::kConflictingBoundsOptions, subst, NULL);

return false;

}