chrome/tools/mac_helpers/infoplist_strings_util.mm - Issue 1227413007: Move ReplaceStringPlaceholders to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/tools/mac_helpers/infoplist_strings_util.mm

Issue 1227413007: Move ReplaceStringPlaceholders to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@join

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/tools/mac_helpers/infoplist_strings_util.mm

diff --git a/chrome/tools/mac_helpers/infoplist_strings_util.mm b/chrome/tools/mac_helpers/infoplist_strings_util.mm

index 765969febc97934345093942c7173055d47a8bb7..1a6804c36162e46e8cb0b92c261260f00c29e2b2 100644

--- a/chrome/tools/mac_helpers/infoplist_strings_util.mm

+++ b/chrome/tools/mac_helpers/infoplist_strings_util.mm

@@ -263,9 +263,8 @@ int main(int argc, char* const argv[]) {

std::vector<base::string16> replacements;

replacements.push_back(base::IntToString16(exploded_time.year));

NSString* copyright = base::SysUTF16ToNSString(

- ReplaceStringPlaceholders(base::SysNSStringToUTF16(copyright_format),

- replacements,

- NULL));

+ base::ReplaceStringPlaceholders(

+ base::SysNSStringToUTF16(copyright_format), replacements, NULL));

// For now, assume this is ok for all languages. If we need to, this could

// be moved into generated_resources.grd and fetched.