content/public/test/render_view_test.cc - Issue 1227413007: Move ReplaceStringPlaceholders to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/render_view_test.cc

Issue 1227413007: Move ReplaceStringPlaceholders to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@join

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/test/render_view_test.cc

diff --git a/content/public/test/render_view_test.cc b/content/public/test/render_view_test.cc

index 52ea9c2bd0287ad2b7a388bf5c83808918390c98..351c3cc29776bca58c2a6cab379dae02bed0445a 100644

--- a/content/public/test/render_view_test.cc

+++ b/content/public/test/render_view_test.cc

@@ -340,7 +340,7 @@ gfx::Rect RenderViewTest::GetElementBounds(const std::string& element_id) {

std::vector<std::string> params;

params.push_back(element_id);

std::string script =

- ReplaceStringPlaceholders(kGetCoordinatesScript, params, NULL);

+ base::ReplaceStringPlaceholders(kGetCoordinatesScript, params, NULL);

v8::Isolate* isolate = v8::Isolate::GetCurrent();

v8::HandleScope handle_scope(isolate);