cloud_print/service/win/cloud_print_service.cc - Issue 1227413007: Move ReplaceStringPlaceholders to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cloud_print/service/win/cloud_print_service.cc

Issue 1227413007: Move ReplaceStringPlaceholders to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@join

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cloud_print/service/win/cloud_print_service.cc

diff --git a/cloud_print/service/win/cloud_print_service.cc b/cloud_print/service/win/cloud_print_service.cc

index b3761d3769fb38af0bb653931f81f7686b6cc1b9..fb73a9fc541224173125bf5c1eb5a6fedb0c8a4f 100644

--- a/cloud_print/service/win/cloud_print_service.cc

+++ b/cloud_print/service/win/cloud_print_service.cc

@@ -90,7 +90,8 @@ base::string16 GetOption(int string_id,

bool secure) {

base::string16 prompt_format = cloud_print::LoadLocalString(string_id);

std::vector<base::string16> substitutions(1, default_option);

- std::cout << ReplaceStringPlaceholders(prompt_format, substitutions, NULL);

+ std::cout <<

+ base::ReplaceStringPlaceholders(prompt_format, substitutions, NULL);

base::string16 tmp;

if (secure) {

DWORD saved_mode = 0;