Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1226673003: Move MatchPattern to its own header and the base namespace. (Closed)

Created:
5 years, 5 months ago by brettw
Modified:
5 years, 5 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, dtseng+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, wfh+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, je_julie, jshin+watch_chromium.org, oshima+watch_chromium.org, tracing+reviews_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, stevenjb+watch_chromium.org, mmenke, davemoore+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move MatchPattern to its own header and the base namespace. BUG= Committed: https://crrev.com/d97eede0d9eb25ebffc918c8ebfcf9a9d9703a88 Cr-Commit-Position: refs/heads/master@{#337488}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+482 lines, -396 lines) Patch
M base/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M base/base.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M base/base.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A base/strings/pattern.h View 1 chunk +26 lines, -0 lines 0 comments Download
A base/strings/pattern.cc View 1 chunk +169 lines, -0 lines 0 comments Download
A base/strings/pattern_unittest.cc View 1 chunk +50 lines, -0 lines 0 comments Download
M base/strings/string_util.h View 1 chunk +0 lines, -10 lines 0 comments Download
M base/strings/string_util.cc View 1 chunk +0 lines, -155 lines 0 comments Download
M base/strings/string_util_unittest.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M base/test/launcher/test_launcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/test/trace_event_analyzer.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M base/trace_event/trace_config.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M base/trace_event/trace_event_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc View 1 14 chunks +43 lines, -35 lines 0 comments Download
M chrome/browser/chromeos/customization/customization_document.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/browsing_data/browsing_data_test.cc View 1 2 3 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/management/management_api_browsertest.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/sessions/sessions_apitest.cc View 1 2 3 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_test.cc View 1 2 3 12 chunks +66 lines, -74 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 2 3 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/plugins/plugin_metadata.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/plugins/plugin_prefs.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest_util.cc View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/trace_event_args_whitelist.cc View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M chrome_elf/elf_imports_unittest.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M components/domain_reliability/config.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/accessibility/accessibility_tree_formatter.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 2 3 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/tracing/background_tracing_manager_browsertest.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M content/child/site_isolation_stats_gatherer_browsertest.cc View 1 2 3 3 chunks +10 lines, -9 lines 0 comments Download
M content/common/appcache_interfaces.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M content/test/image_decoder_test.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M device/serial/serial_device_enumerator_mac.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M extensions/common/manifest_handlers/webview_info.cc View 2 chunks +2 lines, -1 line 0 comments Download
M extensions/common/manifest_test.cc View 1 2 3 4 2 chunks +4 lines, -2 lines 0 comments Download
M extensions/common/url_pattern.cc View 2 chunks +2 lines, -1 line 0 comments Download
M extensions/common/user_script.cc View 2 chunks +2 lines, -1 line 0 comments Download
M extensions/shell/browser/shell_nacl_browser_delegate_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/shell/common/shell_content_client_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M extensions/utility/unpacker_unittest.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M media/filters/stream_parser_factory.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M net/base/host_mapping_rules.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M net/cert/mock_cert_verifier.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/dns/mock_host_resolver.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/proxy/proxy_bypass_rules.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M url/origin.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 31 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226673003/20001
5 years, 5 months ago (2015-07-05 20:35:25 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/70222) (exceeded global ...
5 years, 5 months ago (2015-07-05 20:44:12 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226673003/40001
5 years, 5 months ago (2015-07-05 22:27:50 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/83910) (exceeded global ...
5 years, 5 months ago (2015-07-05 22:43:57 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226673003/60001
5 years, 5 months ago (2015-07-05 23:10:42 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/83912) (exceeded global ...
5 years, 5 months ago (2015-07-05 23:29:56 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226673003/70001
5 years, 5 months ago (2015-07-05 23:43:14 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/82186) mac_chromium_rel_ng on ...
5 years, 5 months ago (2015-07-06 00:00:49 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226673003/90001
5 years, 5 months ago (2015-07-06 00:16:44 UTC) #18
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-06 01:18:41 UTC) #20
brettw
5 years, 5 months ago (2015-07-06 21:11:10 UTC) #22
Elliot Glaysher
read base. rubber stamp lgtm the rest.
5 years, 5 months ago (2015-07-06 21:18:47 UTC) #23
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226673003/90001
5 years, 5 months ago (2015-07-06 21:33:26 UTC) #25
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-06 21:42:14 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226673003/90001
5 years, 5 months ago (2015-07-06 21:59:35 UTC) #29
commit-bot: I haz the power
Committed patchset #6 (id:90001)
5 years, 5 months ago (2015-07-06 22:09:11 UTC) #30
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 22:11:17 UTC) #31
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/d97eede0d9eb25ebffc918c8ebfcf9a9d9703a88
Cr-Commit-Position: refs/heads/master@{#337488}

Powered by Google App Engine
This is Rietveld 408576698