extensions/common/manifest_test.cc - Issue 1226673003: Move MatchPattern to its own header and the base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/manifest_test.cc

Issue 1226673003: Move MatchPattern to its own header and the base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/common/manifest_test.cc

diff --git a/extensions/common/manifest_test.cc b/extensions/common/manifest_test.cc

index a3712d07d4a66454981d3277f5610b44ec778641..2dfdaaa5a147c0108b9c7e9cf4c7c02aafd96a1c 100644

--- a/extensions/common/manifest_test.cc

+++ b/extensions/common/manifest_test.cc

@@ -8,6 +8,7 @@

#include "base/files/file_util.h"

#include "base/json/json_file_value_serializer.h"

#include "base/path_service.h"

+#include "base/strings/pattern.h"

#include "base/strings/string_util.h"

#include "base/values.h"

#include "extensions/common/extension_l10n_util.h"

@@ -167,8 +168,9 @@ void ManifestTest::VerifyExpectedError(

EXPECT_FALSE(extension) <<

"Expected failure loading extension '" << name <<

"', but didn't get one.";

- EXPECT_TRUE(MatchPattern(error, expected_error)) << name <<

- " expected '" << expected_error << "' but got '" << error << "'";

+ EXPECT_TRUE(base::MatchPattern(error, expected_error))

+ << name << " expected '" << expected_error << "' but got '" << error

+ << "'";

}

void ManifestTest::LoadAndExpectError(

« no previous file with comments | « extensions/common/manifest_handlers/webview_info.cc ('k') | extensions/common/url_pattern.cc » ('j') | no next file with comments »