Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Side by Side Diff: extensions/shell/common/shell_content_client_unittest.cc

Issue 1226673003: Move MatchPattern to its own header and the base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/shell/common/shell_content_client.h" 5 #include "extensions/shell/common/shell_content_client.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/strings/pattern.h"
9 #include "base/strings/string_util.h" 10 #include "base/strings/string_util.h"
10 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
11 12
12 typedef testing::Test ShellContentClientTest; 13 typedef testing::Test ShellContentClientTest;
13 14
14 namespace extensions { 15 namespace extensions {
15 16
16 // Tests that the app_shell user agent looks like a Chrome user agent. 17 // Tests that the app_shell user agent looks like a Chrome user agent.
17 TEST_F(ShellContentClientTest, UserAgentFormat) { 18 TEST_F(ShellContentClientTest, UserAgentFormat) {
18 ShellContentClient client; 19 ShellContentClient client;
19 std::string user_agent = client.GetUserAgent(); 20 std::string user_agent = client.GetUserAgent();
20 21
21 // Must start with the usual Mozilla-compatibility string. 22 // Must start with the usual Mozilla-compatibility string.
22 EXPECT_TRUE(base::StartsWithASCII(user_agent, "Mozilla/5.0", false)) 23 EXPECT_TRUE(base::StartsWithASCII(user_agent, "Mozilla/5.0", false))
23 << user_agent; 24 << user_agent;
24 25
25 // Must contain a substring like "Chrome/1.2.3.4". 26 // Must contain a substring like "Chrome/1.2.3.4".
26 EXPECT_TRUE(MatchPattern(user_agent, "*Chrome/*.*.*.*")) << user_agent; 27 EXPECT_TRUE(base::MatchPattern(user_agent, "*Chrome/*.*.*.*")) << user_agent;
27 } 28 }
28 29
29 } // namespace extensions 30 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/shell/browser/shell_nacl_browser_delegate_unittest.cc ('k') | extensions/utility/unpacker_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698