chrome/browser/extensions/api/management/management_api_browsertest.cc - Issue 1226673003: Move MatchPattern to its own header and the base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/management/management_api_browsertest.cc

Issue 1226673003: Move MatchPattern to its own header and the base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/browsing_data/browsing_data_test.cc ('k') | chrome/browser/extensions/api/sessions/sessions_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/management/management_api_browsertest.cc

diff --git a/chrome/browser/extensions/api/management/management_api_browsertest.cc b/chrome/browser/extensions/api/management/management_api_browsertest.cc

index 45e5405765d5e0b68ef3c1192dfe4cd6a9a2f775..f1bed3804a732b304f725c2e4c5046d09f60fa30 100644

--- a/chrome/browser/extensions/api/management/management_api_browsertest.cc

+++ b/chrome/browser/extensions/api/management/management_api_browsertest.cc

@@ -4,6 +4,7 @@

#include "base/files/file_path.h"

#include "base/files/scoped_temp_dir.h"

+#include "base/strings/pattern.h"

#include "base/strings/string_util.h"

#include "base/strings/stringprintf.h"

#include "chrome/browser/extensions/extension_browsertest.h"

@@ -129,7 +130,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementApiBrowserTest,

create_shortcut_function = new ManagementCreateAppShortcutFunction();

create_shortcut_function->set_user_gesture(true);

ManagementCreateAppShortcutFunction::SetAutoConfirmForTest(false);

- EXPECT_TRUE(MatchPattern(

+ EXPECT_TRUE(base::MatchPattern(

util::RunFunctionAndReturnError(

create_shortcut_function.get(),

base::StringPrintf("[\"%s\"]", app_id.c_str()),