chrome/browser/extensions/api/sessions/sessions_apitest.cc - Issue 1226673003: Move MatchPattern to its own header and the base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/sessions/sessions_apitest.cc

Issue 1226673003: Move MatchPattern to its own header and the base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/management/management_api_browsertest.cc ('k') | chrome/browser/extensions/api/tabs/tabs_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/sessions/sessions_apitest.cc

diff --git a/chrome/browser/extensions/api/sessions/sessions_apitest.cc b/chrome/browser/extensions/api/sessions/sessions_apitest.cc

index ccf77bcecfde4914f5732f9c3e429d58d3303001..90ebba80a6259eb86377a3700d4270ba8aed71a8 100644

--- a/chrome/browser/extensions/api/sessions/sessions_apitest.cc

+++ b/chrome/browser/extensions/api/sessions/sessions_apitest.cc

@@ -6,6 +6,7 @@

#include "base/command_line.h"

#include "base/path_service.h"

+#include "base/strings/pattern.h"

#include "base/strings/stringprintf.h"

#include "chrome/browser/extensions/api/tabs/tabs_api.h"

#include "chrome/browser/extensions/extension_apitest.h"

@@ -347,7 +348,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionSessionsTest,

IN_PROC_BROWSER_TEST_F(ExtensionSessionsTest, RestoreForeignSessionInvalidId) {

CreateSessionModels();

- EXPECT_TRUE(MatchPattern(utils::RunFunctionAndReturnError(

+ EXPECT_TRUE(base::MatchPattern(utils::RunFunctionAndReturnError(

CreateFunction<SessionsRestoreFunction>(true).get(),

"[\"tag3.0\"]",

browser_), "Invalid session id: \"tag3.0\"."));

@@ -356,7 +357,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionSessionsTest, RestoreForeignSessionInvalidId) {

IN_PROC_BROWSER_TEST_F(ExtensionSessionsTest, RestoreInIncognito) {

CreateSessionModels();

- EXPECT_TRUE(MatchPattern(utils::RunFunctionAndReturnError(

+ EXPECT_TRUE(base::MatchPattern(utils::RunFunctionAndReturnError(

CreateFunction<SessionsRestoreFunction>(true).get(),

"[\"1\"]",

CreateIncognitoBrowser()),