chrome/browser/extensions/api/tabs/tabs_api.cc - Issue 1226673003: Move MatchPattern to its own header and the base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs_api.cc

Issue 1226673003: Move MatchPattern to its own header and the base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/tabs/tabs_api.cc

diff --git a/chrome/browser/extensions/api/tabs/tabs_api.cc b/chrome/browser/extensions/api/tabs/tabs_api.cc

index 2b51226c9b4dc97802e75d30be79e5fcfdd595c9..eb9cfa9275b1385148a7e2d12fa16af92716c663 100644

--- a/chrome/browser/extensions/api/tabs/tabs_api.cc

+++ b/chrome/browser/extensions/api/tabs/tabs_api.cc

@@ -16,6 +16,7 @@

#include "base/prefs/pref_service.h"

#include "base/single_thread_task_runner.h"

#include "base/stl_util.h"

+#include "base/strings/pattern.h"

#include "base/strings/string16.h"

#include "base/strings/string_number_conversions.h"

#include "base/strings/string_util.h"

@@ -951,8 +952,8 @@ bool TabsQueryFunction::RunSync() {

continue;

}

- if (!title.empty() && !MatchPattern(web_contents->GetTitle(),

- base::UTF8ToUTF16(title)))

+ if (!title.empty() && !base::MatchPattern(web_contents->GetTitle(),

+ base::UTF8ToUTF16(title)))

continue;

if (!url_patterns.is_empty() &&

« no previous file with comments | « chrome/browser/extensions/api/sessions/sessions_apitest.cc ('k') | chrome/browser/extensions/api/tabs/tabs_test.cc » ('j') | no next file with comments »