Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12254007: Make the Isolate parameter mandatory for internal HandleScopes. (Closed)

Created:
7 years, 10 months ago by Sven Panne
Modified:
7 years, 10 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Make the Isolate parameter mandatory for internal HandleScopes. Improved Frames and their iterators on the way, too. BUG=v8:2487 Committed: http://code.google.com/p/v8/source/detail?r=13674

Patch Set 1 #

Patch Set 2 : Removed non-Isolate version #

Patch Set 3 : Rebased #

Patch Set 4 : Improved frames and iterators #

Patch Set 5 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+451 lines, -434 lines) Patch
M src/accessors.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M src/api.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/bootstrapper.h View 5 chunks +9 lines, -6 lines 0 comments Download
M src/bootstrapper.cc View 26 chunks +72 lines, -66 lines 0 comments Download
M src/builtins.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M src/debug.h View 1 chunk +1 line, -1 line 0 comments Download
M src/debug.cc View 1 2 3 5 chunks +7 lines, -7 lines 0 comments Download
M src/elements.cc View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download
M src/frames.h View 1 2 3 5 chunks +7 lines, -8 lines 0 comments Download
M src/frames.cc View 1 2 3 5 chunks +7 lines, -19 lines 0 comments Download
M src/handles.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/handles-inl.h View 1 1 chunk +0 lines, -11 lines 0 comments Download
M src/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic.cc View 1 2 3 18 chunks +26 lines, -27 lines 0 comments Download
M src/isolate.cc View 1 2 3 13 chunks +16 lines, -15 lines 0 comments Download
M src/liveedit.cc View 1 2 3 14 chunks +27 lines, -23 lines 0 comments Download
M src/log.h View 1 3 chunks +4 lines, -2 lines 0 comments Download
M src/log.cc View 1 7 chunks +13 lines, -10 lines 0 comments Download
M src/messages.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/messages.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M src/objects.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/profile-generator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime.cc View 1 2 3 18 chunks +25 lines, -23 lines 0 comments Download
M src/stub-cache.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M src/type-info.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-accessors.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 2 chunks +6 lines, -3 lines 0 comments Download
M test/cctest/test-heap.cc View 1 39 chunks +102 lines, -72 lines 0 comments Download
M test/cctest/test-log-stack-tracer.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-macro-assembler-x64.cc View 1 22 chunks +66 lines, -88 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-serialize.cc View 1 2 chunks +11 lines, -7 lines 0 comments Download
M test/cctest/test-strings.cc View 1 6 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
7 years, 10 months ago (2013-02-14 12:51:40 UTC) #1
Sven Panne
New patch set, PTAL again...
7 years, 10 months ago (2013-02-14 14:24:29 UTC) #2
Yang
7 years, 10 months ago (2013-02-15 09:14:41 UTC) #3 
On 2013/02/14 14:24:29, Sven Panne wrote:
> New patch set, PTAL again...

LGTM.

Powered by Google App Engine
This is Rietveld 408576698